From 2dd64cf9628c1f061169f03baf898326b3bd432f Mon Sep 17 00:00:00 2001 From: paul luse Date: Mon, 11 Apr 2022 12:45:34 -0700 Subject: [PATCH] examples/accel_perf: fail correctly when we can't get a channel By design there is a limit to how many channels the idxd driver can suport based on how many DSA instances are available. When we reach the limit we won't be able to get a channel. This fixes that error path to fail gracefully instead of seg faulting. Signed-off-by: paul luse Change-Id: I226f59913cb830eae0707623ae251ba19bce9aaf Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12218 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk Reviewed-by: Jim Harris --- examples/accel/perf/accel_perf.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/examples/accel/perf/accel_perf.c b/examples/accel/perf/accel_perf.c index e56778964..ef21f0c7e 100644 --- a/examples/accel/perf/accel_perf.c +++ b/examples/accel/perf/accel_perf.c @@ -701,6 +701,10 @@ _init_thread(void *arg1) g_workers = worker; pthread_mutex_unlock(&g_workers_lock); worker->ch = spdk_accel_engine_get_io_channel(); + if (worker->ch == NULL) { + fprintf(stderr, "Unable to get an accel channel\n"); + goto error; + } TAILQ_INIT(&worker->tasks_pool); @@ -757,7 +761,6 @@ error: free(worker->rnd_data); _free_task_buffers_in_pool(worker); free(worker->task_base); - free(worker); spdk_app_stop(-1); }