From 2db4a553819e2bde3d46661ee8d223a14380c94d Mon Sep 17 00:00:00 2001 From: Jim Harris Date: Tue, 24 Jan 2023 20:38:34 +0000 Subject: [PATCH] ublk: sort cmd_op case statements in ublk_ctrl_cmd Sort the case statements by the normal order in which the commands are submitted. Signed-off-by: Jim Harris Change-Id: I203a70045cd48d30d1229c754ddb57e7e31460af Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16455 Tested-by: SPDK CI Jenkins Reviewed-by: Xiaodong Liu Reviewed-by: Konrad Sztyber Reviewed-by: Tomasz Zawadzki --- lib/ublk/ublk.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/ublk/ublk.c b/lib/ublk/ublk.c index 3eae17b44..4fa4e7052 100644 --- a/lib/ublk/ublk.c +++ b/lib/ublk/ublk.c @@ -248,25 +248,25 @@ ublk_ctrl_cmd(struct spdk_ublk_dev *ublk, uint32_t cmd_op) ublk->next_state_fn = NULL; switch (cmd_op) { - case UBLK_CMD_START_DEV: - cmd->data[0] = getpid(); - cmd->data[1] = 0; - break; case UBLK_CMD_ADD_DEV: ublk->next_state_fn = ublk_set_params; cmd->addr = (__u64)(uintptr_t)&ublk->dev_info; cmd->len = sizeof(ublk->dev_info); break; - case UBLK_CMD_STOP_DEV: - break; - case UBLK_CMD_DEL_DEV: - ublk->next_state_fn = ublk_delete_dev; - break; case UBLK_CMD_SET_PARAMS: ublk->next_state_fn = ublk_finish_start; cmd->addr = (__u64)(uintptr_t)&ublk->dev_params; cmd->len = sizeof(ublk->dev_params); break; + case UBLK_CMD_START_DEV: + cmd->data[0] = getpid(); + cmd->data[1] = 0; + break; + case UBLK_CMD_STOP_DEV: + break; + case UBLK_CMD_DEL_DEV: + ublk->next_state_fn = ublk_delete_dev; + break; default: SPDK_ERRLOG("No match cmd operation,cmd_op = %d\n", cmd_op); return -EINVAL;