From 2c28fa5426072ce6567ac7520294bfa880874d8c Mon Sep 17 00:00:00 2001 From: Daniel Verkamp Date: Wed, 12 Jul 2017 09:35:03 -0700 Subject: [PATCH] test/json_util_ut: assert that string is valid Make sure the output.my_name pointer is not NULL before calling memcmp() on it. Fixes static analysis warning about a potential NULL pointer dereference. Change-Id: I85faf57c63b0760c4f90d9ee99f6d7e3df121211 Signed-off-by: Daniel Verkamp Reviewed-on: https://review.gerrithub.io/369264 Tested-by: SPDK Automated Test System Reviewed-by: Ben Walker Reviewed-by: Jim Harris --- test/unit/lib/json/json_util.c/json_util_ut.c | 1 + 1 file changed, 1 insertion(+) diff --git a/test/unit/lib/json/json_util.c/json_util_ut.c b/test/unit/lib/json/json_util.c/json_util_ut.c index 11cc0817c..8c99c870c 100644 --- a/test/unit/lib/json/json_util.c/json_util_ut.c +++ b/test/unit/lib/json/json_util.c/json_util_ut.c @@ -175,6 +175,7 @@ test_decode_object(void) /* Passing Test: object containing simple types */ CU_ASSERT(spdk_json_decode_object(object, decoders, 4, &output) == 0); + SPDK_CU_ASSERT_FATAL(output.my_name != NULL); CU_ASSERT(memcmp(output.my_name, answer_str, 6) == 0); CU_ASSERT(output.my_int == answer); CU_ASSERT(output.my_bool == answer_bool);