ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bdev/nvme: Merge clearing nvme_ns->populated into nvme_ctrlr_depopulate_namespace_done()

Browse Source 
Merge setting nvme_ns->populated to false into
nvme_ctrlr_depopulate_namespace_done(). This will simplify the
further changes.

Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Change-Id: I4bb8347b085ec5855690f6dbde243269cedee706
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7136
Community-CI: Broadcom CI
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
This commit is contained in:
Shuhei Matsumoto 2021-03-29 23:57:03 +09:00 committed by Jim Harris
parent b1d6c2f3cb
commit 2bed9983e2
3 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
module/bdev/nvme/bdev_nvme.c
View File

@ -1539,8 +1539,6 @@ nvme_ctrlr_depopulate_standard_namespace(struct nvme_bdev_ns *nvme_ns)
spdk_bdev_unregister(&bdev->disk, NULL, NULL);
}
nvme_ns->populated = false;
nvme_ctrlr_depopulate_namespace_done(nvme_ns);
}

2
module/bdev/nvme/bdev_ocssd.c
View File

@ -906,8 +906,6 @@ bdev_ocssd_free_namespace(struct nvme_bdev_ns *nvme_ns)
free(nvme_ns->type_ctx);
nvme_ns->type_ctx = NULL;
nvme_ns->populated = false;
nvme_ctrlr_depopulate_namespace_done(nvme_ns);
}

3
module/bdev/nvme/common.c
View File

@ -194,6 +194,9 @@ nvme_ctrlr_depopulate_namespace_done(struct nvme_bdev_ns *nvme_ns)
assert(nvme_bdev_ctrlr != NULL);
pthread_mutex_lock(&nvme_bdev_ctrlr->mutex);
nvme_ns->populated = false;
assert(nvme_ns->ref > 0);
nvme_ns->ref--;
if (nvme_ns->ref > 0) {