ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

env: make spdk_env_get_last_core() thread safe

Browse Source 
Previously, the maximum core value was cached in a static variable, but
this isn't safe if multiple threads are calling at the same time.

Iterating over all core numbers is not very expensive, so just
recalculate the value for every call.

Change-Id: I4fab072f4a96ecc8801e1db293b3921a6f1534f9
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/399930
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
This commit is contained in:
Daniel Verkamp 2018-02-14 11:17:08 -07:00 committed by Jim Harris
parent ff3d53f74e
commit 2b8c23c7b8
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/env_dpdk/threads.c
View File

@ -58,12 +58,7 @@ uint32_t
spdk_env_get_last_core(void)
{
uint32_t i;
static uint32_t last_core = UINT32_MAX;
/* Already know the last_core, just return */
if (last_core != UINT32_MAX) {
return last_core;
}
uint32_t last_core = UINT32_MAX;
SPDK_ENV_FOREACH_CORE(i) {
last_core = i;