From 29977e8506eebba6fd00ba3fb25051ed249fdb0e Mon Sep 17 00:00:00 2001 From: Jonas Pfefferle Date: Sun, 21 Aug 2022 12:37:46 +0200 Subject: [PATCH] bdev: add additional io types in dump bdev info Add indication of support for compare, compare & write and abort in json bdev info dump. Signed-off-by: Jonas Pfefferle Change-Id: Ifc8dc1a1b180f08fcd9e9d58684eab1fd50356ff Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14137 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins Reviewed-by: Dong Yi Reviewed-by: Aleksey Marchuk Reviewed-by: Ben Walker --- lib/bdev/bdev_rpc.c | 6 ++++++ test/spdkcli/match_files/spdkcli_details_vhost.test.match | 3 +++ 2 files changed, 9 insertions(+) diff --git a/lib/bdev/bdev_rpc.c b/lib/bdev/bdev_rpc.c index cdd136cef..eeecef923 100644 --- a/lib/bdev/bdev_rpc.c +++ b/lib/bdev/bdev_rpc.c @@ -468,6 +468,12 @@ rpc_dump_bdev_info(void *ctx, struct spdk_bdev *bdev) spdk_bdev_io_type_supported(bdev, SPDK_BDEV_IO_TYPE_FLUSH)); spdk_json_write_named_bool(w, "reset", spdk_bdev_io_type_supported(bdev, SPDK_BDEV_IO_TYPE_RESET)); + spdk_json_write_named_bool(w, "compare", + spdk_bdev_io_type_supported(bdev, SPDK_BDEV_IO_TYPE_COMPARE)); + spdk_json_write_named_bool(w, "compare_and_write", + spdk_bdev_io_type_supported(bdev, SPDK_BDEV_IO_TYPE_COMPARE_AND_WRITE)); + spdk_json_write_named_bool(w, "abort", + spdk_bdev_io_type_supported(bdev, SPDK_BDEV_IO_TYPE_ABORT)); spdk_json_write_named_bool(w, "nvme_admin", spdk_bdev_io_type_supported(bdev, SPDK_BDEV_IO_TYPE_NVME_ADMIN)); spdk_json_write_named_bool(w, "nvme_io", diff --git a/test/spdkcli/match_files/spdkcli_details_vhost.test.match b/test/spdkcli/match_files/spdkcli_details_vhost.test.match index 05195d3a3..b5aa7fe27 100644 --- a/test/spdkcli/match_files/spdkcli_details_vhost.test.match +++ b/test/spdkcli/match_files/spdkcli_details_vhost.test.match @@ -20,6 +20,9 @@ "num_blocks": $(N), "product_name": "Split Disk", "supported_io_types": { + "abort": $(S), + "compare": $(S), + "compare_and_write": $(S), "flush": $(S), "nvme_admin": $(S), "nvme_io": $(S),