From 29907b7240876bf9f2b16f7f0f6f90c31302b992 Mon Sep 17 00:00:00 2001
From: Michal Berger <michalx.berger@intel.com>
Date: Thu, 5 Aug 2021 09:53:49 +0200
Subject: [PATCH] test/common: Be verbose in waitforserial()

Signed-off-by: Michal Berger <michalx.berger@intel.com>
Change-Id: I9c01e786c4d9df1b5a0f61b0ab354a3fd2546672
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9085
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
---
 test/common/autotest_common.sh | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/test/common/autotest_common.sh b/test/common/autotest_common.sh
index c09fa6371..c4ed486aa 100755
--- a/test/common/autotest_common.sh
+++ b/test/common/autotest_common.sh
@@ -1028,7 +1028,7 @@ function print_backtrace() {
 
 function waitforserial() {
 	local i=0
-	local nvme_device_counter=1
+	local nvme_device_counter=1 nvme_devices=0
 	if [[ -n "$2" ]]; then
 		nvme_device_counter=$2
 	fi
@@ -1039,7 +1039,11 @@ function waitforserial() {
 	# (unless kernel is rebooted) and which start to negatively affect all the tests.
 	sleep 2
 	while ((i++ <= 15)); do
-		(($(lsblk -l -o NAME,SERIAL | grep -c "$1") == nvme_device_counter)) && return 0
+		nvme_devices=$(lsblk -l -o NAME,SERIAL | grep -c "$1")
+		((nvme_devices == nvme_device_counter)) && return 0
+		if ((nvme_devices > nvme_device_counter)); then
+			echo "$nvme_device_counter device(s) expected, found $nvme_devices" >&2
+		fi
 		echo "Waiting for devices"
 		sleep 1
 	done