ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bdev: remove leading underscore from _bdev_io_(inc|dec)rement_outstanding

Browse Source 
The leading underscore usually indicate that a function providing the
actual implementation for something that's called from some other
wrapper function without the leading underscore.  That is not the case
for these functions, so this patch removes the leading underscores.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I6e1186b156116249ee53a3845ae99ba87db5122b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17868
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
This commit is contained in:
Konrad Sztyber 2023-04-27 16:08:57 +02:00 committed by David Ko
parent 1280245cb2
commit 29651a8971
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
lib/bdev/bdev.c
View File

@ -1018,16 +1018,16 @@ bdev_io_needs_sequence_exec(struct spdk_bdev_desc *desc, struct spdk_bdev_io *bd
}
static inline void
_bdev_io_increment_outstanding(struct spdk_bdev_channel *bdev_ch,
struct spdk_bdev_shared_resource *shared_resource)
bdev_io_increment_outstanding(struct spdk_bdev_channel *bdev_ch,
struct spdk_bdev_shared_resource *shared_resource)
{
bdev_ch->io_outstanding++;
shared_resource->io_outstanding++;
}
static inline void
_bdev_io_decrement_outstanding(struct spdk_bdev_channel *bdev_ch,
struct spdk_bdev_shared_resource *shared_resource)
bdev_io_decrement_outstanding(struct spdk_bdev_channel *bdev_ch,
struct spdk_bdev_shared_resource *shared_resource)
{
assert(bdev_ch->io_outstanding > 0);
assert(shared_resource->io_outstanding > 0);
@ -1394,7 +1394,7 @@ bdev_ch_resubmit_io(struct spdk_bdev_channel *bdev_ch, struct spdk_bdev_io *bdev
{
struct spdk_bdev *bdev = bdev_ch->bdev;
_bdev_io_increment_outstanding(bdev_io->internal.ch, bdev_ch->shared_resource);
bdev_io_increment_outstanding(bdev_io->internal.ch, bdev_ch->shared_resource);
bdev_io->internal.error.nvme.cdw0 = 0;
bdev_io->num_retries++;
bdev_submit_request(bdev, spdk_bdev_io_get_io_channel(bdev_io), bdev_io);
@ -1488,7 +1488,7 @@ _bdev_io_complete_push_bounce_done(void *ctx, int rc)
bdev_io_put_buf(bdev_io);
/* Continue with IO completion flow */
_bdev_io_decrement_outstanding(bdev_ch, shared_resource);
bdev_io_decrement_outstanding(bdev_ch, shared_resource);
if (spdk_unlikely(_bdev_io_handle_no_mem(bdev_io, BDEV_IO_RETRY_STATE_INVALID))) {
return;
}
@ -6991,7 +6991,7 @@ bdev_io_complete_sequence_cb(void *ctx, int status)
bdev_io->internal.status = SPDK_BDEV_IO_STATUS_FAILED;
}
_bdev_io_decrement_outstanding(bdev_ch, shared_resource);
bdev_io_decrement_outstanding(bdev_ch, shared_resource);
if (spdk_unlikely(_bdev_io_handle_no_mem(bdev_io, BDEV_IO_RETRY_STATE_INVALID))) {
return;
}
@ -7045,7 +7045,7 @@ spdk_bdev_io_complete(struct spdk_bdev_io *bdev_io, enum spdk_bdev_io_status sta
}
}
_bdev_io_decrement_outstanding(bdev_ch, shared_resource);
bdev_io_decrement_outstanding(bdev_ch, shared_resource);
if (spdk_unlikely(_bdev_io_handle_no_mem(bdev_io, BDEV_IO_RETRY_STATE_SUBMIT))) {
return;
}