From 2705f6f10d773cd3f2db8ab0c0726eeedcb96de8 Mon Sep 17 00:00:00 2001 From: Dariusz Stojaczyk Date: Fri, 18 Aug 2017 15:22:25 +0200 Subject: [PATCH] Fixed all SPDK_LOG() calls without newline char Change-Id: Ib9a6b3e7584c5edd8f8c0f8cd20349d86651a5a2 Signed-off-by: Dariusz Stojaczyk Reviewed-on: https://review.gerrithub.io/374780 Tested-by: SPDK Automated Test System Reviewed-by: Pawel Wodkowski Reviewed-by: Daniel Verkamp Reviewed-by: Ben Walker --- examples/bdev/fio_plugin/fio_plugin.c | 2 +- lib/bdev/bdev.c | 2 +- lib/iscsi/conn.c | 2 +- lib/iscsi/iscsi.c | 2 +- lib/scsi/lun.c | 2 +- lib/scsi/scsi_bdev.c | 2 +- lib/vhost/vhost.c | 4 ++-- lib/vhost/vhost_blk.c | 2 +- lib/vhost/vhost_scsi.c | 4 ++-- 9 files changed, 11 insertions(+), 11 deletions(-) diff --git a/examples/bdev/fio_plugin/fio_plugin.c b/examples/bdev/fio_plugin/fio_plugin.c index f453043b6..e104c4b2c 100644 --- a/examples/bdev/fio_plugin/fio_plugin.c +++ b/examples/bdev/fio_plugin/fio_plugin.c @@ -247,7 +247,7 @@ spdk_fio_init_env(struct thread_data *td) return -1; } if (spdk_conf_first_section(config) == NULL) { - SPDK_ERRLOG("Invalid configuration file format"); + SPDK_ERRLOG("Invalid configuration file format\n"); spdk_conf_free(config); return -1; } diff --git a/lib/bdev/bdev.c b/lib/bdev/bdev.c index 5ee523f77..966d1cf6b 100644 --- a/lib/bdev/bdev.c +++ b/lib/bdev/bdev.c @@ -444,7 +444,7 @@ spdk_bdev_initialize(spdk_bdev_init_cb cb_fn, void *cb_arg, SPDK_ENV_SOCKET_ID_ANY); if (g_bdev_mgr.bdev_io_pool == NULL) { - SPDK_ERRLOG("could not allocate spdk_bdev_io pool"); + SPDK_ERRLOG("could not allocate spdk_bdev_io pool\n"); spdk_bdev_module_init_complete(-1); return; } diff --git a/lib/iscsi/conn.c b/lib/iscsi/conn.c index 272398be5..c7b8c89e6 100644 --- a/lib/iscsi/conn.c +++ b/lib/iscsi/conn.c @@ -889,7 +889,7 @@ spdk_iscsi_drop_conns(struct spdk_iscsi_conn *conn, const char *conn_match, conn->target->name, conn_match); } - SPDK_ERRLOG("exiting conn by %s (%s)", + SPDK_ERRLOG("exiting conn by %s (%s)\n", xconn_match, xconn->initiator_addr); if (xconn->sess != NULL) { SPDK_TRACELOG(SPDK_TRACE_ISCSI, "TSIH=%u\n", xconn->sess->tsih); diff --git a/lib/iscsi/iscsi.c b/lib/iscsi/iscsi.c index 195a358d0..9be408a6e 100644 --- a/lib/iscsi/iscsi.c +++ b/lib/iscsi/iscsi.c @@ -4087,7 +4087,7 @@ static int spdk_iscsi_op_data(struct spdk_iscsi_conn *conn, } if (pdu->data_segment_len > task->desired_data_transfer_length) { - SPDK_ERRLOG("the dataout pdu data length is larger than the value sent by R2T PDU"); + SPDK_ERRLOG("the dataout pdu data length is larger than the value sent by R2T PDU\n"); return SPDK_ISCSI_CONNECTION_FATAL; } diff --git a/lib/scsi/lun.c b/lib/scsi/lun.c index ab0933808..c7d3c8b22 100644 --- a/lib/scsi/lun.c +++ b/lib/scsi/lun.c @@ -352,7 +352,7 @@ spdk_scsi_lun_delete(const char *lun_name) pthread_mutex_lock(&g_spdk_scsi.mutex); lun = spdk_lun_db_get_lun(lun_name); if (lun == NULL) { - SPDK_ERRLOG("LUN '%s' not found", lun_name); + SPDK_ERRLOG("LUN '%s' not found\n", lun_name); pthread_mutex_unlock(&g_spdk_scsi.mutex); return -1; } diff --git a/lib/scsi/scsi_bdev.c b/lib/scsi/scsi_bdev.c index 9a70f3257..a0cf9c200 100644 --- a/lib/scsi/scsi_bdev.c +++ b/lib/scsi/scsi_bdev.c @@ -1524,7 +1524,7 @@ __copy_desc(struct spdk_bdev_scsi_unmap_ctx *ctx, uint8_t *data, size_t data_len desc_count = desc_data_len / 16; if (desc_data_len > (data_len - 8)) { - SPDK_ERRLOG("Error - desc_data_len (%u) > data_len (%lu) - 8", + SPDK_ERRLOG("Error - desc_data_len (%u) > data_len (%lu) - 8\n", desc_data_len, data_len); return -EINVAL; } diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c index ba7824897..d693e50b5 100644 --- a/lib/vhost/vhost.c +++ b/lib/vhost/vhost.c @@ -383,7 +383,7 @@ spdk_vhost_dev_construct(struct spdk_vhost_dev *vdev, const char *name, uint64_t if (rte_vhost_driver_start(path) != 0) { spdk_strerror_r(errno, buf, sizeof(buf)); - SPDK_ERRLOG("Failed to start vhost driver for controller %s (%d): %s", name, errno, + SPDK_ERRLOG("Failed to start vhost driver for controller %s (%d): %s\n", name, errno, buf); rte_vhost_driver_unregister(path); return -EIO; @@ -698,7 +698,7 @@ spdk_vhost_shutdown_cb(void) if (pthread_create(&tid, NULL, &session_shutdown, NULL) < 0) { spdk_strerror_r(errno, buf, sizeof(buf)); - SPDK_ERRLOG("Failed to start session shutdown thread (%d): %s", errno, buf); + SPDK_ERRLOG("Failed to start session shutdown thread (%d): %s\n", errno, buf); abort(); } pthread_detach(tid); diff --git a/lib/vhost/vhost_blk.c b/lib/vhost/vhost_blk.c index 27be74cb0..c0b846ff3 100644 --- a/lib/vhost/vhost_blk.c +++ b/lib/vhost/vhost_blk.c @@ -534,7 +534,7 @@ new_device(struct spdk_vhost_dev *vdev) rc = alloc_task_pool(bvdev); if (rc != 0) { - SPDK_ERRLOG("%s: failed to alloc task pool.", bvdev->vdev.name); + SPDK_ERRLOG("%s: failed to alloc task pool.\n", bvdev->vdev.name); return -1; } diff --git a/lib/vhost/vhost_scsi.c b/lib/vhost/vhost_scsi.c index c06a95e70..45c9d64bf 100644 --- a/lib/vhost/vhost_scsi.c +++ b/lib/vhost/vhost_scsi.c @@ -1110,14 +1110,14 @@ new_device(struct spdk_vhost_dev *vdev) rc = alloc_task_pool(svdev); if (rc != 0) { - SPDK_ERRLOG("%s: failed to alloc task pool.", vdev->name); + SPDK_ERRLOG("%s: failed to alloc task pool.\n", vdev->name); return -1; } svdev->vhost_events = spdk_ring_create(SPDK_RING_TYPE_MP_SC, 16, spdk_env_get_socket_id(vdev->lcore)); if (svdev->vhost_events == NULL) { - SPDK_ERRLOG("%s: failed to alloc event pool.", vdev->name); + SPDK_ERRLOG("%s: failed to alloc event pool.\n", vdev->name); return -1; }