From 26979c50c7f8d8abf5e9549f530aa28f1c53ba96 Mon Sep 17 00:00:00 2001 From: Chunyang Hui Date: Mon, 21 Jan 2019 09:56:47 -0500 Subject: [PATCH] app/parse: add default return value for app parse function Change-Id: Icae46bb96502c7edf3a453e0fff1d8560241c5ab Signed-off-by: Chunyang Hui Reviewed-on: https://review.gerrithub.io/c/441277 Tested-by: SPDK CI Jenkins Reviewed-by: Darek Stojaczyk Reviewed-by: Shuhei Matsumoto --- app/iscsi_tgt/iscsi_tgt.c | 3 +-- app/spdk_tgt/spdk_tgt.c | 2 ++ app/vhost/vhost.c | 2 ++ examples/bdev/hello_world/hello_bdev.c | 2 ++ examples/sock/hello_world/hello_sock.c | 3 +++ test/bdev/bdevperf/bdevperf.c | 2 ++ test/blobfs/mkfs/mkfs.c | 2 +- 7 files changed, 13 insertions(+), 3 deletions(-) diff --git a/app/iscsi_tgt/iscsi_tgt.c b/app/iscsi_tgt/iscsi_tgt.c index b81e91895..eea5c666c 100644 --- a/app/iscsi_tgt/iscsi_tgt.c +++ b/app/iscsi_tgt/iscsi_tgt.c @@ -79,8 +79,7 @@ iscsi_parse_arg(int ch, char *arg) g_daemon_mode = 1; break; default: - assert(false); - break; + return -EINVAL; } return 0; } diff --git a/app/spdk_tgt/spdk_tgt.c b/app/spdk_tgt/spdk_tgt.c index 515c7f8cf..482d612c2 100644 --- a/app/spdk_tgt/spdk_tgt.c +++ b/app/spdk_tgt/spdk_tgt.c @@ -89,6 +89,8 @@ spdk_tgt_parse_arg(int ch, char *arg) spdk_vhost_set_socket_path(arg); break; #endif + default: + return -EINVAL; } return 0; } diff --git a/app/vhost/vhost.c b/app/vhost/vhost.c index 1271e5682..15b78e7c5 100644 --- a/app/vhost/vhost.c +++ b/app/vhost/vhost.c @@ -72,6 +72,8 @@ vhost_parse_arg(int ch, char *arg) case 'S': spdk_vhost_set_socket_path(arg); break; + default: + return -EINVAL; } return 0; } diff --git a/examples/bdev/hello_world/hello_bdev.c b/examples/bdev/hello_world/hello_bdev.c index 7278226d4..305a65561 100644 --- a/examples/bdev/hello_world/hello_bdev.c +++ b/examples/bdev/hello_world/hello_bdev.c @@ -73,6 +73,8 @@ static int hello_bdev_parse_arg(int ch, char *arg) case 'b': g_bdev_name = arg; break; + default: + return -EINVAL; } return 0; } diff --git a/examples/sock/hello_world/hello_sock.c b/examples/sock/hello_world/hello_sock.c index 246cb7e96..b21412d44 100644 --- a/examples/sock/hello_world/hello_sock.c +++ b/examples/sock/hello_world/hello_sock.c @@ -105,6 +105,9 @@ static int hello_sock_parse_arg(int ch, char *arg) break; case 'V': g_verbose = true; + break; + default: + return -EINVAL; } return 0; } diff --git a/test/bdev/bdevperf/bdevperf.c b/test/bdev/bdevperf/bdevperf.c index 3c31eac9c..ab9f9a9d9 100644 --- a/test/bdev/bdevperf/bdevperf.c +++ b/test/bdev/bdevperf/bdevperf.c @@ -852,6 +852,8 @@ bdevperf_parse_arg(int ch, char *arg) g_show_performance_period_in_usec = spdk_max(g_show_performance_period_in_usec, g_show_performance_period_in_usec); break; + default: + return -EINVAL; } return 0; } diff --git a/test/blobfs/mkfs/mkfs.c b/test/blobfs/mkfs/mkfs.c index 7d65ad393..0de638642 100644 --- a/test/blobfs/mkfs/mkfs.c +++ b/test/blobfs/mkfs/mkfs.c @@ -113,7 +113,7 @@ mkfs_parse_arg(int ch, char *arg) spdk_parse_capacity(arg, &g_cluster_size, &has_prefix); break; default: - break; + return -EINVAL; } return 0; }