From 266ca9401317d10eeb71127e21e77937f1241e6a Mon Sep 17 00:00:00 2001 From: Seth Howell Date: Wed, 17 Jul 2019 01:04:32 -0700 Subject: [PATCH] Revert "shared_lib: add as_needed to the libspdk.so linker script" This reverts commit 346fefc364235c869ddef21958fc34e0393a8426. That commit breaks the shared object build when linking against the implicit top level linker script. It makes it so that none of the constructor functions get properly linked in. Change-Id: I3477acbd86f44b6d5e949eb6725ca4c1b71a55b5 Signed-off-by: Seth Howell Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/462149 Tested-by: SPDK CI Jenkins Reviewed-by: Darek Stojaczyk Reviewed-by: Changpeng Liu --- shared_lib/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shared_lib/Makefile b/shared_lib/Makefile index 909bf49f6..2dfbaf5ce 100644 --- a/shared_lib/Makefile +++ b/shared_lib/Makefile @@ -47,7 +47,7 @@ SPDK_SHARED_LIBS := $(filter-out $(IGNORED_LIBS), $(sort $(notdir $(wildcard $(S $(SHARED_REALNAME_LIB): $(Q)echo " SO $(notdir $@)"; \ - echo "GROUP ( AS_NEEDED ( $(SPDK_SHARED_LIBS) ) )" > $(SHARED_REALNAME_LIB) + echo "GROUP ( $(SPDK_SHARED_LIBS) )" > $(SHARED_REALNAME_LIB) $(SHARED_LINKED_LIB) : $(SHARED_REALNAME_LIB) $(Q)echo " SYMLINK $(notdir $@)"; $(BUILD_LINKERNAME_LIB)