From 25270f1d7ccf44e9f1ecbf68718e50ef873c77ef Mon Sep 17 00:00:00 2001 From: Ben Walker Date: Wed, 1 Feb 2017 14:34:45 -0700 Subject: [PATCH] Rename instance_id to shm_id and make it default to pid By default, all SPDK applications will not share memory. To share memory, start the applications with the same shared memory id. Change-Id: Ib6180369ef0ed12d05983a21d7943e467402b21a Signed-off-by: Ben Walker --- app/iscsi_tgt/iscsi_tgt.c | 4 +-- app/iscsi_top/iscsi_top.cpp | 12 +++---- app/nvmf_tgt/nvmf_tgt.c | 4 +-- app/trace/trace.cpp | 8 ++--- etc/spdk/iscsi.conf.in | 6 ++-- examples/nvme/arbitration/arbitration.c | 37 +++++++++++++++++---- examples/nvme/perf/perf.c | 37 +++++++++++++++++---- include/spdk/event.h | 6 ++-- lib/event/app.c | 22 ++++++------ lib/event/dpdk_init.c | 4 +-- lib/iscsi/conn.c | 2 +- test/iscsi_tgt/ip_migration/ip_migration.sh | 2 +- test/lib/nvme/nvme.sh | 8 ++--- test/lib/nvme/nvmemp.sh | 30 ++++++++--------- 14 files changed, 116 insertions(+), 66 deletions(-) diff --git a/app/iscsi_tgt/iscsi_tgt.c b/app/iscsi_tgt/iscsi_tgt.c index 253ee8727..2adee1c9a 100644 --- a/app/iscsi_tgt/iscsi_tgt.c +++ b/app/iscsi_tgt/iscsi_tgt.c @@ -71,7 +71,7 @@ usage(char *executable_name) printf(" -c config config file (default %s)\n", SPDK_ISCSI_DEFAULT_CONFIG); printf(" -e mask tracepoint group mask for spdk trace buffers (default 0x0)\n"); printf(" -m mask core mask for DPDK\n"); - printf(" -i instance ID\n"); + printf(" -i shared memory ID (optional)\n"); printf(" -l facility use specific syslog facility (default %s)\n", opts.log_facility); printf(" -n channel number of memory channels used for DPDK\n"); @@ -116,7 +116,7 @@ main(int argc, char **argv) opts.config_file = optarg; break; case 'i': - opts.instance_id = atoi(optarg); + opts.shm_id = atoi(optarg); break; case 'l': opts.log_facility = optarg; diff --git a/app/iscsi_top/iscsi_top.cpp b/app/iscsi_top/iscsi_top.cpp index 38f40e973..58acf63a0 100644 --- a/app/iscsi_top/iscsi_top.cpp +++ b/app/iscsi_top/iscsi_top.cpp @@ -54,14 +54,14 @@ extern "C" { } static char *exe_name; -static int g_instance_id = 0; +static int g_shm_id = 0; static void usage(void) { fprintf(stderr, "usage:\n"); fprintf(stderr, " %s