ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test/iscsi: check and avoid setting DataDigest

Browse Source 
iscsiadm installed by some Fedora releases, like Fedora 27,
loses DataDigest parameter unintelligibly.

Change-Id: I6664146c6e0cb8933188b29166bedd087f4d38e1
Signed-off-by: Xiaodong Liu <xiaodong.liu@intel.com>
Reviewed-on: https://review.gerrithub.io/396076
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
This commit is contained in:
Xiaodong Liu 2018-01-23 21:31:07 -05:00 committed by Jim Harris
parent 4151703690
commit 24c7f62fed
1 changed files with 56 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

84
test/iscsi_tgt/digests/digests.sh
View File

@ -15,6 +15,54 @@ function node_login_fio_logout()
sleep 1 sleep 1
} }
function iscsi_header_digest_test()
{
# Enable HeaderDigest to CRC32C
timing_enter HeaderDigest_enabled
iscsiadm -m node -p $TARGET_IP:$PORT -o update -n node.conn[0].iscsi.HeaderDigest -v CRC32C
node_login_fio_logout
timing_exit HeaderDigest_enabled
# Let iscsi target to decide its preference on
# HeaderDigest based on its capability.
timing_enter preferred
iscsiadm -m node -p $TARGET_IP:$PORT -o update -n node.conn[0].iscsi.HeaderDigest -v CRC32C,None
node_login_fio_logout
timing_exit preferred
}
function iscsi_header_data_digest_test()
{
# Only enable HeaderDigest to CRC32C
timing_enter HeaderDigest_enabled
iscsiadm -m node -p $TARGET_IP:$PORT -o update -n node.conn[0].iscsi.HeaderDigest -v CRC32C
iscsiadm -m node -p $TARGET_IP:$PORT -o update -n node.conn[0].iscsi.DataDigest -v None
node_login_fio_logout
timing_exit HeaderDigest_enabled
# Only enable DataDigest to CRC32C
timing_enter DataDigest_enabled
iscsiadm -m node -p $TARGET_IP:$PORT -o update -n node.conn[0].iscsi.HeaderDigest -v None
iscsiadm -m node -p $TARGET_IP:$PORT -o update -n node.conn[0].iscsi.DataDigest -v CRC32C
node_login_fio_logout
timing_exit DataDigest_enabled
# Let iscsi target to decide its preference on both
# HeaderDigest and DataDigest based on its capability.
timing_enter both_preferred
iscsiadm -m node -p $TARGET_IP:$PORT -o update -n node.conn[0].iscsi.HeaderDigest -v CRC32C,None
iscsiadm -m node -p $TARGET_IP:$PORT -o update -n node.conn[0].iscsi.DataDigest -v CRC32C,None
node_login_fio_logout
timing_exit both_preferred
# Enable HeaderDigest and DataDigest both.
timing_enter both_enabled
iscsiadm -m node -p $TARGET_IP:$PORT -o update -n node.conn[0].iscsi.HeaderDigest -v CRC32C
iscsiadm -m node -p $TARGET_IP:$PORT -o update -n node.conn[0].iscsi.DataDigest -v CRC32C
node_login_fio_logout
timing_exit both_enabled
}
timing_enter digests timing_enter digests
# iSCSI target configuration # iSCSI target configuration
@ -53,34 +101,14 @@ sleep 1
iscsiadm -m discovery -t sendtargets -p $TARGET_IP:$PORT iscsiadm -m discovery -t sendtargets -p $TARGET_IP:$PORT
# Only enable HeaderDigest to CRC32C # iscsiadm installed by some Fedora releases loses DataDigest parameter.
timing_enter HeaderDigest_enabled # Check and avoid setting DataDigest.
iscsiadm -m node -p $TARGET_IP:$PORT -o update -n node.conn[0].iscsi.HeaderDigest -v CRC32C DataDigestAbility=`iscsiadm -m node -p $TARGET_IP:$PORT | grep DataDigest || true`
iscsiadm -m node -p $TARGET_IP:$PORT -o update -n node.conn[0].iscsi.DataDigest -v None if [ "$DataDigestAbility"x = x ]; then
node_login_fio_logout iscsi_header_digest_test
timing_exit HeaderDigest_enabled else
iscsi_header_data_digest_test
# Only enable DataDigest to CRC32C fi
timing_enter DataDigest_enabled
iscsiadm -m node -p $TARGET_IP:$PORT -o update -n node.conn[0].iscsi.HeaderDigest -v None
iscsiadm -m node -p $TARGET_IP:$PORT -o update -n node.conn[0].iscsi.DataDigest -v CRC32C
node_login_fio_logout
timing_exit DataDigest_enabled
# Let iscsi target to decide its preference on both
# HeaderDigest and DataDigest based on its capability.
timing_enter both_preferred
iscsiadm -m node -p $TARGET_IP:$PORT -o update -n node.conn[0].iscsi.HeaderDigest -v CRC32C,None
iscsiadm -m node -p $TARGET_IP:$PORT -o update -n node.conn[0].iscsi.DataDigest -v CRC32C,None
node_login_fio_logout
timing_exit both_preferred
# Enable HeaderDigest and DataDigest both.
timing_enter both_enabled
iscsiadm -m node -p $TARGET_IP:$PORT -o update -n node.conn[0].iscsi.HeaderDigest -v CRC32C
iscsiadm -m node -p $TARGET_IP:$PORT -o update -n node.conn[0].iscsi.DataDigest -v CRC32C
node_login_fio_logout
timing_exit both_enabled
trap - SIGINT SIGTERM EXIT trap - SIGINT SIGTERM EXIT