From 24605155098bb2652cbe5dbc1301da8b4e62ca69 Mon Sep 17 00:00:00 2001
From: Chuanwei Ji <chuanwei.ji@jaguarmicro.com>
Date: Tue, 19 Jul 2022 15:14:02 +0800
Subject: [PATCH] aio: aio rescan rpc response is sent incorrectly.

Failed rpc response will be sent when rescan successfully.

Signed-off-by: Chuanwei Ji <chuanwei.ji@jaguarmicro.com>
Change-Id: I99a2491ec76b63cb01fb384e621b41b10ee0ed83
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13711
Community-CI: Mellanox Build Bot
Reviewed-by: Qingmin Liu <qingmin.liu@jaguarmicro.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Dong Yi <dongx.yi@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
---
 module/bdev/aio/bdev_aio_rpc.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/module/bdev/aio/bdev_aio_rpc.c b/module/bdev/aio/bdev_aio_rpc.c
index a684046af..973924e93 100644
--- a/module/bdev/aio/bdev_aio_rpc.c
+++ b/module/bdev/aio/bdev_aio_rpc.c
@@ -106,8 +106,13 @@ rpc_bdev_aio_rescan(struct spdk_jsonrpc_request *request,
 	}
 
 	bdeverrno = bdev_aio_rescan(req.name);
-	spdk_jsonrpc_send_bool_response(request, bdeverrno);
+	if (bdeverrno) {
+		spdk_jsonrpc_send_error_response(request, bdeverrno,
+						 spdk_strerror(-bdeverrno));
+		goto cleanup;
+	}
 
+	spdk_jsonrpc_send_bool_response(request, true);
 cleanup:
 	free(req.name);
 }