From 242a899573540d9956416a2571825bff85d4a24e Mon Sep 17 00:00:00 2001 From: Darek Stojaczyk Date: Wed, 12 Feb 2020 13:40:44 +0100 Subject: [PATCH] autobuild: don't silence errtrap with leading ! Apparently some shellcheck versions on our CI complain about it and suggest to use && exit 1 instead, we'll try to use || true instead. Change-Id: Idb505770a80929fbb9957f4ba039e009aae98f02 Signed-off-by: Darek Stojaczyk Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/835 Reviewed-by: Tomasz Zawadzki Reviewed-by: Karol Latecki Tested-by: SPDK CI Jenkins --- autobuild.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/autobuild.sh b/autobuild.sh index fefa461ee..243aeba5d 100755 --- a/autobuild.sh +++ b/autobuild.sh @@ -72,8 +72,8 @@ function scanbuild_make { # from comm manual: # -2 suppress column 2 (lines unique to FILE2) # -3 suppress column 3 (lines that appear in both files) - # comm may exit 1 if no lines were printed (undocumented) - ! comm -2 -3 $out/all_c_files.txt $out/built_c_files.txt > $out/unbuilt_c_files.txt + # comm may exit 1 if no lines were printed (undocumented, unreliable) + comm -2 -3 $out/all_c_files.txt $out/built_c_files.txt > $out/unbuilt_c_files.txt || true if [ $(wc -l < $out/unbuilt_c_files.txt) -ge 1 ]; then echo "missing files"