From 22e5037e0c0846489b2f6f22a3bbae4fa29a4086 Mon Sep 17 00:00:00 2001 From: Jim Harris Date: Thu, 4 Mar 2021 23:53:24 +0000 Subject: [PATCH] scsi: relax spdk_scsi_task_gather_data assert If the iov_len is 0, it is OK for the iov_base to be NULL. Reported-by: Yi Ren Signed-off-by: Jim Harris Change-Id: I45c9be68fc2975bf2abd91a9d77935ce516c5210 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6706 Reviewed-by: Paul Luse Reviewed-by: Changpeng Liu Reviewed-by: Shuhei Matsumoto Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build Bot --- lib/scsi/task.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/scsi/task.c b/lib/scsi/task.c index 7fd8305ec..6abfc4961 100644 --- a/lib/scsi/task.c +++ b/lib/scsi/task.c @@ -158,7 +158,8 @@ spdk_scsi_task_gather_data(struct spdk_scsi_task *task, int *len) uint8_t *buf, *pos; for (i = 0; i < task->iovcnt; i++) { - assert(iovs[i].iov_base != NULL); + /* It is OK for iov_base to be NULL if iov_len is 0. */ + assert(iovs[i].iov_base != NULL || iovs[i].iov_len == 0); buf_len += iovs[i].iov_len; }