From 218fd85dc10fa04d33241749318a235b697cb4b0 Mon Sep 17 00:00:00 2001 From: Dariusz Stojaczyk Date: Fri, 17 Aug 2018 16:39:25 +0200 Subject: [PATCH] bdevio: check spdk_app_parse_args return code This makes us exit immediately on '-h' or any parsing error. Change-Id: I6bd2fc9238bcecba6df1e62a8db42ce79ad73524 Signed-off-by: Dariusz Stojaczyk Reviewed-on: https://review.gerrithub.io/422686 Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Ben Walker Chandler-Test-Pool: SPDK Automated Test System --- test/bdev/bdevio/bdevio.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/test/bdev/bdevio/bdevio.c b/test/bdev/bdevio/bdevio.c index 407057e5a..b4b401374 100644 --- a/test/bdev/bdevio/bdevio.c +++ b/test/bdev/bdevio/bdevio.c @@ -952,7 +952,7 @@ bdevio_parse_arg(int ch, char *arg) int main(int argc, char **argv) { - int num_failures; + int rc; struct spdk_app_opts opts = {}; spdk_app_opts_init(&opts); @@ -962,11 +962,14 @@ main(int argc, char **argv) opts.reactor_mask = "0x7"; opts.mem_size = 1024; - spdk_app_parse_args(argc, argv, &opts, "", NULL, - bdevio_parse_arg, bdevio_usage); + if ((rc = spdk_app_parse_args(argc, argv, &opts, "", NULL, + bdevio_parse_arg, bdevio_usage)) != + SPDK_APP_PARSE_ARGS_SUCCESS) { + return rc; + } - num_failures = spdk_app_start(&opts, test_main, NULL, NULL); + rc = spdk_app_start(&opts, test_main, NULL, NULL); spdk_app_fini(); - return num_failures; + return rc; }