From 20d8fec0397f335cc9fc776eeda6238e144a2111 Mon Sep 17 00:00:00 2001 From: Dariusz Stojaczyk Date: Wed, 4 Apr 2018 14:29:57 +0200 Subject: [PATCH] bdev/virtio/scsi: fix bdev->name memory leak This must have been overlooked before. Change-Id: I631c7b926970d045e9e91cada535acd605e05b6e Signed-off-by: Dariusz Stojaczyk Reviewed-on: https://review.gerrithub.io/406334 Tested-by: SPDK Automated Test System Reviewed-by: Pawel Wodkowski Reviewed-by: Daniel Verkamp Reviewed-by: Jim Harris --- lib/bdev/virtio/bdev_virtio_scsi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/bdev/virtio/bdev_virtio_scsi.c b/lib/bdev/virtio/bdev_virtio_scsi.c index 743cf5bfd..86204b2a0 100644 --- a/lib/bdev/virtio/bdev_virtio_scsi.c +++ b/lib/bdev/virtio/bdev_virtio_scsi.c @@ -664,6 +664,7 @@ bdev_virtio_disk_destruct(void *ctx) struct virtio_scsi_dev *svdev = disk->svdev; TAILQ_REMOVE(&svdev->luns, disk, link); + free(disk->bdev.name); free(disk); if (svdev->removed && TAILQ_EMPTY(&svdev->luns)) { @@ -1292,6 +1293,7 @@ virtio_scsi_dev_add_tgt(struct virtio_scsi_dev *svdev, struct virtio_scsi_scan_i rc = spdk_bdev_register(&disk->bdev); if (rc) { SPDK_ERRLOG("Failed to register bdev name=%s\n", disk->bdev.name); + free(bdev->name); free(disk); return rc; }