From 20acc18bf3d7b3fbb4a2564532d88246df34a661 Mon Sep 17 00:00:00 2001 From: Dariusz Stojaczyk Date: Sun, 25 Mar 2018 14:17:30 +0200 Subject: [PATCH] bdev/virtio: fix tailq corruption on failed init Each device was being removed from the tailq twice. virtio_scsi_dev_remove does the removal by itself. Change-Id: I2320fc88ac60ddd5952b07b26c679c8f2e887976 Signed-off-by: Dariusz Stojaczyk Reviewed-on: https://review.gerrithub.io/405180 Tested-by: SPDK Automated Test System Reviewed-by: Shuhei Matsumoto Reviewed-by: Pawel Wodkowski Reviewed-by: Daniel Verkamp --- lib/bdev/virtio/bdev_virtio_scsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/bdev/virtio/bdev_virtio_scsi.c b/lib/bdev/virtio/bdev_virtio_scsi.c index 93957920f..a1e90360d 100644 --- a/lib/bdev/virtio/bdev_virtio_scsi.c +++ b/lib/bdev/virtio/bdev_virtio_scsi.c @@ -1726,7 +1726,6 @@ bdev_virtio_initialize(void) out: /* Remove any created devices */ TAILQ_FOREACH_SAFE(svdev, &g_virtio_scsi_devs, tailq, next_svdev) { - TAILQ_REMOVE(&g_virtio_scsi_devs, svdev, tailq); virtio_scsi_dev_remove(svdev, NULL, NULL); }