ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scripts/nvmf_perf: fix pylint R0201

Browse Source 
Fix pylint findings:
- R0201 Method could be a function

Signed-off-by: Pawel Piatek <pawelx.piatek@intel.com>
Change-Id: I1b9141b9ab150e20fdcd63510b484c6be514efb5
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12137
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
This commit is contained in:
Pawel Piatek 2022-04-03 08:13:29 +02:00 committed by Tomasz Zawadzki
parent 6d98816767
commit 20955a4938
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
scripts/perf/nvmf/run_nvmf.py
View File

@ -62,7 +62,8 @@ class Server:
def log_print(self, msg): def log_print(self, msg):
print("[%s] %s" % (self.name, msg), flush=True) print("[%s] %s" % (self.name, msg), flush=True)
def get_uncommented_lines(self, lines): @staticmethod
def get_uncommented_lines(lines):
return [line for line in lines if line and not line.startswith('#')] return [line for line in lines if line and not line.startswith('#')]
def get_nic_name_by_ip(self, ip): def get_nic_name_by_ip(self, ip):
@ -92,6 +93,7 @@ class Server:
self.local_nic_info = extract_network_elements(pci_info) self.local_nic_info = extract_network_elements(pci_info)
# pylint: disable=R0201
def exec_cmd(self, cmd, stderr_redirect=False, change_dir=None): def exec_cmd(self, cmd, stderr_redirect=False, change_dir=None):
return "" return ""
@ -414,7 +416,8 @@ class Target(Server):
fh.close() fh.close()
self.log_print("Done zipping") self.log_print("Done zipping")
def read_json_stats(self, file): @staticmethod
def read_json_stats(file):
with open(file, "r") as json_data: with open(file, "r") as json_data:
data = json.load(json_data) data = json.load(json_data)
job_pos = 0 # job_post = 0 because using aggregated results job_pos = 0 # job_post = 0 because using aggregated results
@ -1074,7 +1077,8 @@ class SPDKTarget(Target):
self.log_print("====IDXD settings:====") self.log_print("====IDXD settings:====")
self.log_print("IDXD enabled: %s" % (self.enable_idxd)) self.log_print("IDXD enabled: %s" % (self.enable_idxd))
def get_num_cores(self, core_mask): @staticmethod
def get_num_cores(core_mask):
if "0x" in core_mask: if "0x" in core_mask:
return bin(int(core_mask, 16)).count("1") return bin(int(core_mask, 16)).count("1")
else: else: