From 1fa071d332db21bf893d581a8e93b425ba788a24 Mon Sep 17 00:00:00 2001 From: Tomasz Zawadzki Date: Mon, 20 Apr 2020 11:48:25 -0400 Subject: [PATCH] conf: provide deprecation message when using INI configuration Deprecating INI tyle configuration has been a long time coming. Feature parity is there between JSON-RPC and INI, which should enable the switch. All major applications support the JSON-RPC and tests were moved to the JSON-RPC. With above in place, it is time to give an explicit notification to INI config users regarding the lack of support for INI. In future release the INI configuration will be removed, until then feedback from users is welcome on any suggestions how to make the transition smoother. Signed-off-by: Tomasz Zawadzki Change-Id: If47375371791646f2afd06762b9bf6c5b8e009ed Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1941 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Ben Walker Reviewed-by: Shuhei Matsumoto --- CHANGELOG.md | 6 ++++++ lib/conf/conf.c | 1 + 2 files changed, 7 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 61f8076fe..a0bc0686a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,12 @@ ## v20.04: (Upcoming Release) +### configuration + +Legacy INI style configuration for SPDK applications has been deprecated and will be +removed in future release. +Please switch to JSON-RPC configuration files and/or RPC driven run-time configuration. + ### ocf Update OCF submodule to OCF v20.03 diff --git a/lib/conf/conf.c b/lib/conf/conf.c index c419b3a19..e9f4b2037 100644 --- a/lib/conf/conf.c +++ b/lib/conf/conf.c @@ -71,6 +71,7 @@ static struct spdk_conf *default_config = NULL; struct spdk_conf * spdk_conf_allocate(void) { + SPDK_ERRLOG("INI configuration has been deprecated and will be removed in a future release. Please switch to JSON-RPC.\n"); return calloc(1, sizeof(struct spdk_conf)); }