From 1f4f4cc75a522f897856e980a0b35d3c8fac24ed Mon Sep 17 00:00:00 2001 From: Seth Howell Date: Wed, 6 May 2020 13:52:16 -0700 Subject: [PATCH] lib/jsonrpc: add a map file. There are several functions in the internal header that are only used in the library that have kept the spdk prefix. Add those to the suppression file since nobody in practice will be using them. Signed-off-by: Seth Howell Change-Id: Iae1666c6f0bb853e62b89858037a5cded38c9b66 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2213 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Shuhei Matsumoto --- lib/jsonrpc/Makefile | 2 ++ lib/jsonrpc/spdk_jsonrpc.map | 28 ++++++++++++++++++++++++++++ test/make/check_so_deps.sh | 16 ++++++++++++++++ 3 files changed, 46 insertions(+) create mode 100644 lib/jsonrpc/spdk_jsonrpc.map diff --git a/lib/jsonrpc/Makefile b/lib/jsonrpc/Makefile index 167aa48e5..38e8ae5fe 100644 --- a/lib/jsonrpc/Makefile +++ b/lib/jsonrpc/Makefile @@ -42,4 +42,6 @@ LIBNAME = jsonrpc C_SRCS = jsonrpc_server.c jsonrpc_server_tcp.c C_SRCS += jsonrpc_client.c jsonrpc_client_tcp.c +SPDK_MAP_FILE = $(abspath $(CURDIR)/spdk_jsonrpc.map) + include $(SPDK_ROOT_DIR)/mk/spdk.lib.mk diff --git a/lib/jsonrpc/spdk_jsonrpc.map b/lib/jsonrpc/spdk_jsonrpc.map new file mode 100644 index 000000000..461fd0766 --- /dev/null +++ b/lib/jsonrpc/spdk_jsonrpc.map @@ -0,0 +1,28 @@ +{ + global: + + # public functions + spdk_jsonrpc_server_listen; + spdk_jsonrpc_server_poll; + spdk_jsonrpc_server_shutdown; + spdk_jsonrpc_get_conn; + spdk_jsonrpc_conn_add_close_cb; + spdk_jsonrpc_conn_del_close_cb; + spdk_jsonrpc_begin_result; + spdk_jsonrpc_end_result; + spdk_jsonrpc_send_error_response; + spdk_jsonrpc_send_error_response_fmt; + spdk_jsonrpc_begin_request; + spdk_jsonrpc_end_request; + spdk_jsonrpc_client_connect; + spdk_jsonrpc_client_close; + spdk_jsonrpc_client_create_request; + spdk_jsonrpc_client_free_request; + spdk_jsonrpc_client_send_request; + spdk_jsonrpc_client_poll; + spdk_jsonrpc_client_get_response; + spdk_jsonrpc_client_free_response; + + + local: *; +}; diff --git a/test/make/check_so_deps.sh b/test/make/check_so_deps.sh index d4f23ae5b..bb73a3c4d 100755 --- a/test/make/check_so_deps.sh +++ b/test/make/check_so_deps.sh @@ -40,6 +40,22 @@ function confirm_abi_deps() { name = SPDK_LOG_IOAT [suppress_variable] name = SPDK_LOG_JSON_UTIL +[suppress_variable] + name = SPDK_LOG_RPC +[suppress_variable] + name = SPDK_LOG_RPC_CLIENT +[suppress_function] + name = spdk_jsonrpc_server_handle_request +[suppress_function] + name = spdk_jsonrpc_server_handle_error +[suppress_function] + name = spdk_jsonrpc_server_send_response +[suppress_function] + name = spdk_jsonrpc_parse_request +[suppress_function] + name = spdk_jsonrpc_free_request +[suppress_function] + name = spdk_jsonrpc_parse_response EOF for object in "$libdir"/libspdk_*.so; do