From 1f3a6b0398dfba2d9aedea1d272e64e55d6f1af6 Mon Sep 17 00:00:00 2001 From: Konrad Sztyber Date: Fri, 14 Oct 2022 16:06:22 +0200 Subject: [PATCH] rpc: use rw access when creating RPC lock file It allows the users to specify the path to the RPC socket on a NFS mounted filesystem. This is necessary, because flock(2) on NFS requires write access to place an exclusive lock. Signed-off-by: Konrad Sztyber Change-Id: If197498ed5bdcb4e02c5f2f2b2c1ef388872c457 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14993 Reviewed-by: Jacek Kalwas Reviewed-by: Tomasz Zawadzki Reviewed-by: Jim Harris Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build Bot --- lib/rpc/rpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rpc/rpc.c b/lib/rpc/rpc.c index b543a2409..c19da685f 100644 --- a/lib/rpc/rpc.c +++ b/lib/rpc/rpc.c @@ -144,7 +144,7 @@ spdk_rpc_listen(const char *listen_addr) return -1; } - g_rpc_lock_fd = open(g_rpc_lock_path, O_RDONLY | O_CREAT, 0600); + g_rpc_lock_fd = open(g_rpc_lock_path, O_RDWR | O_CREAT, 0600); if (g_rpc_lock_fd == -1) { SPDK_ERRLOG("Cannot open lock file %s: %s\n", g_rpc_lock_path, spdk_strerror(errno));