From 1c2291bab9b55810d46b372c96156ecf9326136c Mon Sep 17 00:00:00 2001 From: Pawel Kaminski Date: Fri, 6 Sep 2019 09:23:08 -0400 Subject: [PATCH] test: Shellcheck - move rule SC2206 to permanent exception list Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. Change-Id: I8d971216056580921ce07baa24e6ceaceffcceae Signed-off-by: Pawel Kaminski Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/467679 Tested-by: SPDK CI Jenkins Reviewed-by: Karol Latecki Reviewed-by: Jim Harris Reviewed-by: Tomasz Zawadzki Reviewed-by: Maciej Wawryk --- scripts/check_format.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/check_format.sh b/scripts/check_format.sh index 6c330bfe0..f7ff0a0dc 100755 --- a/scripts/check_format.sh +++ b/scripts/check_format.sh @@ -248,7 +248,7 @@ SC2068,SC2086,SC2089,SC2090,\ SC2097,SC2098,SC2103,SC2115,SC2116,SC2119,SC2120,SC2121,SC2124,SC2126,SC2128,\ SC2129,SC2140,SC2142,SC2143,SC2145,SC2146,SC2148,SC2152,SC2153,SC2154,SC2155,\ SC2162,SC2164,SC2165,SC2166,SC2167,SC2174,\ -SC2206,SC2230" +SC2230" # SPDK fails some error checks which have been deprecated in later versions of shellcheck. # We will not try to fix these error checks, but instead just leave the error types here # so that we can still run with older versions of shellcheck. @@ -257,9 +257,11 @@ SC2206,SC2230" # We are aware about below exclude list and we want this errors to be excluded. # SC1090: Can't follow non-constant source. Use a directive to specify location. # SC1091: Not following: (error message here) + # SC2206: Quote to prevent word splitting/globbing, + # or split robustly with mapfile or read -a. # SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting). # SC2223: This default assignment may cause DoS due to globbing. Quote it. - SHCK_EXCLUDE="$SHCK_EXCLUDE,SC1090,SC1091,SC2207,SC2223" + SHCK_EXCLUDE="$SHCK_EXCLUDE,SC1090,SC1091,SC2206,SC2207,SC2223" SHCK_FORMAT="diff" SHCK_APPLY=true