From 1b49dcefcb0a8fbb7fcdbfb1d5bde4b2dd16024e Mon Sep 17 00:00:00 2001 From: Konrad Sztyber Date: Tue, 14 Mar 2023 08:13:00 +0100 Subject: [PATCH] build: rely on configure to select which unit tests to build There's no reason to check the OS to decide whether to build some unit tests if we can rely on the configure parameters. For instance, on FreeBSD, RDMA unit tests can be built and run successfully, while vhost is always disabled in configure. Fixes #2941. Signed-off-by: Konrad Sztyber Change-Id: I0073783dcafa932f3a7f48fa553e04be7ae44f84 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17182 Reviewed-by: Ben Walker Tested-by: SPDK CI Jenkins Reviewed-by: Karol Latecki Reviewed-by: Jim Harris Community-CI: Mellanox Build Bot --- test/unit/lib/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/unit/lib/Makefile b/test/unit/lib/Makefile index 2082ee662..d7d7fe664 100644 --- a/test/unit/lib/Makefile +++ b/test/unit/lib/Makefile @@ -10,10 +10,10 @@ DIRS-y = accel bdev blob blobfs dma event ioat iscsi json jsonrpc log lvol DIRS-y += notify nvme nvmf scsi sock thread util env_dpdk init rpc DIRS-$(CONFIG_IDXD) += idxd DIRS-$(CONFIG_VBDEV_COMPRESS) += reduce -ifeq ($(OS),Linux) DIRS-$(CONFIG_VHOST) += vhost -DIRS-y += ftl DIRS-$(CONFIG_RDMA) += rdma +ifeq ($(OS),Linux) +DIRS-y += ftl endif .PHONY: all clean $(DIRS-y)