From 1ac578d42cc57769cb36456dd067a5bf0c9bd500 Mon Sep 17 00:00:00 2001 From: Shuhei Matsumoto Date: Wed, 1 Dec 2021 17:27:59 +0900 Subject: [PATCH] example/nvme_perf: Remove spdk_nvme_poll_group_remove() calls spdk_nvme_ctrlr_free_io_qpair() calls spdk_nvme_poll_group_remove() internally. Signed-off-by: Shuhei Matsumoto Change-Id: I0085eb74c1aa2e5a318a980b2916fa20693c8d12 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10662 Community-CI: Broadcom CI Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Aleksey Marchuk --- examples/nvme/perf/perf.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/examples/nvme/perf/perf.c b/examples/nvme/perf/perf.c index 9896834d3..e28778911 100644 --- a/examples/nvme/perf/perf.c +++ b/examples/nvme/perf/perf.c @@ -5,7 +5,7 @@ * All rights reserved. * * Copyright (c) 2019-2021 Mellanox Technologies LTD. All rights reserved. - * Copyright (c) 2021 NVIDIA CORPORATION & AFFILIATES. All rights reserved. + * Copyright (c) 2021, 2022 NVIDIA CORPORATION & AFFILIATES. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -991,7 +991,6 @@ nvme_init_ns_worker_ctx(struct ns_worker_ctx *ns_ctx) if (spdk_nvme_ctrlr_connect_io_qpair(entry->u.nvme.ctrlr, qpair)) { printf("ERROR: unable to connect I/O qpair.\n"); - spdk_nvme_poll_group_remove(group, qpair); spdk_nvme_ctrlr_free_io_qpair(qpair); goto qpair_failed; } @@ -1001,7 +1000,6 @@ nvme_init_ns_worker_ctx(struct ns_worker_ctx *ns_ctx) qpair_failed: for (; i > 0; --i) { - spdk_nvme_poll_group_remove(ns_ctx->u.nvme.group, ns_ctx->u.nvme.qpair[i - 1]); spdk_nvme_ctrlr_free_io_qpair(ns_ctx->u.nvme.qpair[i - 1]); } @@ -1017,7 +1015,6 @@ nvme_cleanup_ns_worker_ctx(struct ns_worker_ctx *ns_ctx) int i; for (i = 0; i < ns_ctx->u.nvme.num_all_qpairs; i++) { - spdk_nvme_poll_group_remove(ns_ctx->u.nvme.group, ns_ctx->u.nvme.qpair[i]); spdk_nvme_ctrlr_free_io_qpair(ns_ctx->u.nvme.qpair[i]); }