From 1a30ba7f251e947bfb82ffec49302b298d01f3ec Mon Sep 17 00:00:00 2001 From: Tomasz Kulasek Date: Mon, 3 Feb 2020 13:39:41 +0100 Subject: [PATCH] bdev/nvme: fix release reference to channel in apply firmware RPC Fixes #1176 Change-Id: Ie694c9cd492fec5486683e6cb04dc11892e0a493 Signed-off-by: Tomasz Kulasek Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/483704 Tested-by: SPDK CI Jenkins Community-CI: Broadcom SPDK FC-NVMe CI Reviewed-by: Jim Harris Reviewed-by: Paul Luse Reviewed-by: Shuhei Matsumoto Reviewed-by: Alexey Marchuk --- module/bdev/nvme/bdev_nvme_rpc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/module/bdev/nvme/bdev_nvme_rpc.c b/module/bdev/nvme/bdev_nvme_rpc.c index 7f13f8ee9..e0e21b969 100644 --- a/module/bdev/nvme/bdev_nvme_rpc.c +++ b/module/bdev/nvme/bdev_nvme_rpc.c @@ -533,6 +533,11 @@ apply_firmware_cleanup(void *cb_arg) free_rpc_apply_firmware(firm_ctx->req); free(firm_ctx->req); } + + if (firm_ctx->ch) { + spdk_put_io_channel(firm_ctx->ch); + } + TAILQ_FOREACH_SAFE(opt, &firm_ctx->desc_head, tqlst, tmp) { TAILQ_REMOVE(&firm_ctx->desc_head, opt, tqlst); spdk_bdev_close(opt->desc);