ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

hexlify util: v2c helper function return type is signed char

Browse Source 
`v2c` helper function returns -1 on error, hovewer its return type was
char - which may cause an overflow situation on architectures where char
is interpreted as unsigned char, which was reported by the CI.
The return type has been changed to signed char.

Signed-off-by: Blachut, Bartosz <bartosz.blachut@intel.com>
Change-Id: I84f5784b2de7d681f78c69b5f3646e851e8dee88
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14273
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jacek Kalwas <jacek.kalwas@intel.com>
This commit is contained in:
Blachut, Bartosz 2022-08-30 18:54:44 +02:00 committed by Tomasz Zawadzki
parent 750896ce36
commit 1a24dc8fef
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
module/bdev/crypto/vbdev_crypto.h
View File

@ -93,7 +93,7 @@ __c2v(char c)
return -1; return -1;
} }
static inline char static inline signed char
__v2c(int c) __v2c(int c)
{ {
const char hexchar[] = "0123456789abcdef"; const char hexchar[] = "0123456789abcdef";
@ -121,8 +121,8 @@ hexlify(const char *bin, size_t len)
} }
phex = hex; phex = hex;
for (size_t i = 0; i < len; i++) { for (size_t i = 0; i < len; i++) {
char c0 = __v2c((bin[i] >> 4) & 0x0f); signed char c0 = __v2c((bin[i] >> 4) & 0x0f);
char c1 = __v2c((bin[i]) & 0x0f); signed char c1 = __v2c((bin[i]) & 0x0f);
if (c0 < 0 || c1 < 0) { if (c0 < 0 || c1 < 0) {
assert(false); assert(false);
free(hex); free(hex);