From 18a2cc11c10a4d5bf8a4081b4f534026a12db755 Mon Sep 17 00:00:00 2001
From: Ben Walker <benjamin.walker@intel.com>
Date: Mon, 3 Oct 2016 14:40:06 -0700
Subject: [PATCH] env: Remove unused DPDK headers.

Remove #includes for all DPDK headers that weren't
necessary.

Change-Id: Ib02522e0f04e64a1c98afceb7508cc0e8d931a9d
Signed-off-by: Ben Walker <benjamin.walker@intel.com>
---
 app/iscsi_tgt/iscsi_tgt.c         |  1 -
 examples/ioat/perf/perf.c         |  2 +-
 examples/ioat/verify/verify.c     |  2 +-
 lib/bdev/bdev.c                   |  1 -
 lib/bdev/malloc/blockdev_malloc.c |  2 --
 lib/bdev/nvme/blockdev_nvme.c     |  5 +----
 lib/copy/copy_engine.c            |  1 +
 lib/copy/ioat/copy_engine_ioat.c  |  5 +----
 lib/iscsi/iscsi.c                 | 13 -------------
 lib/iscsi/iscsi_subsystem.c       | 21 ++++-----------------
 lib/nvmf/nvmf.c                   |  2 --
 lib/nvmf/rdma.c                   |  3 ---
 test/lib/bdev/bdevio/bdevio.c     |  4 ----
 test/lib/bdev/bdevperf/bdevperf.c |  2 --
 test/lib/nvme/sgl/nvme_sgl.c      |  2 +-
 test/lib/nvmf/nvmf/nvmf_ut.c      |  3 ---
 16 files changed, 10 insertions(+), 59 deletions(-)

diff --git a/app/iscsi_tgt/iscsi_tgt.c b/app/iscsi_tgt/iscsi_tgt.c
index 6d6723fb7..3307d7498 100644
--- a/app/iscsi_tgt/iscsi_tgt.c
+++ b/app/iscsi_tgt/iscsi_tgt.c
@@ -36,7 +36,6 @@
 #include <stdlib.h>
 
 #include <rte_config.h>
-#include <rte_eal.h>
 #include <rte_lcore.h>
 
 #include "spdk/env.h"
diff --git a/examples/ioat/perf/perf.c b/examples/ioat/perf/perf.c
index 2f0f6204c..2f3c29f2a 100644
--- a/examples/ioat/perf/perf.c
+++ b/examples/ioat/perf/perf.c
@@ -36,8 +36,8 @@
 #include <stdlib.h>
 #include <stdbool.h>
 #include <string.h>
+
 #include <rte_config.h>
-#include <rte_eal.h>
 #include <rte_lcore.h>
 
 #include "spdk/ioat.h"
diff --git a/examples/ioat/verify/verify.c b/examples/ioat/verify/verify.c
index 730b412fb..950851dcf 100644
--- a/examples/ioat/verify/verify.c
+++ b/examples/ioat/verify/verify.c
@@ -36,9 +36,9 @@
 #include <stdlib.h>
 #include <stdbool.h>
 #include <string.h>
+
 #include <rte_config.h>
 #include <rte_lcore.h>
-#include <rte_eal.h>
 
 #include "spdk/ioat.h"
 #include "spdk/env.h"
diff --git a/lib/bdev/bdev.c b/lib/bdev/bdev.c
index 7c7056525..213a15227 100644
--- a/lib/bdev/bdev.c
+++ b/lib/bdev/bdev.c
@@ -40,7 +40,6 @@
 #include <unistd.h>
 
 #include <rte_config.h>
-#include <rte_ring.h>
 #include <rte_mempool.h>
 #include <rte_version.h>
 
diff --git a/lib/bdev/malloc/blockdev_malloc.c b/lib/bdev/malloc/blockdev_malloc.c
index 86c5c6701..467c6edca 100644
--- a/lib/bdev/malloc/blockdev_malloc.c
+++ b/lib/bdev/malloc/blockdev_malloc.c
@@ -34,8 +34,6 @@
 
 #include <stdio.h>
 #include <errno.h>
-#include <rte_config.h>
-#include <rte_memcpy.h>
 
 #include "blockdev_malloc.h"
 #include "spdk/bdev.h"
diff --git a/lib/bdev/nvme/blockdev_nvme.c b/lib/bdev/nvme/blockdev_nvme.c
index 784444699..32f9ede46 100644
--- a/lib/bdev/nvme/blockdev_nvme.c
+++ b/lib/bdev/nvme/blockdev_nvme.c
@@ -35,15 +35,12 @@
 #include <stdio.h>
 #include <stdint.h>
 #include <stdbool.h>
+#include <stdlib.h>
 #include <errno.h>
 #include <sys/param.h>
 
 #include <pthread.h>
 
-#include <rte_config.h>
-#include <rte_ring.h>
-#include <rte_lcore.h>
-
 #include "spdk/conf.h"
 #include "spdk/endian.h"
 #include "spdk/env.h"
diff --git a/lib/copy/copy_engine.c b/lib/copy/copy_engine.c
index 4694f6f4e..f245a4bb7 100644
--- a/lib/copy/copy_engine.c
+++ b/lib/copy/copy_engine.c
@@ -36,6 +36,7 @@
 #include <assert.h>
 #include <stdio.h>
 #include <errno.h>
+
 #include <rte_config.h>
 #include <rte_memcpy.h>
 
diff --git a/lib/copy/ioat/copy_engine_ioat.c b/lib/copy/ioat/copy_engine_ioat.c
index 34fc7d0f8..122c33c5f 100644
--- a/lib/copy/ioat/copy_engine_ioat.c
+++ b/lib/copy/ioat/copy_engine_ioat.c
@@ -34,10 +34,7 @@
 #include <assert.h>
 #include <stdio.h>
 #include <errno.h>
-
-#include <rte_config.h>
-#include <rte_memcpy.h>
-#include <rte_lcore.h>
+#include <pthread.h>
 
 #include "spdk/copy_engine.h"
 #include "spdk/env.h"
diff --git a/lib/iscsi/iscsi.c b/lib/iscsi/iscsi.c
index bb4f27be5..f8cd8ec64 100644
--- a/lib/iscsi/iscsi.c
+++ b/lib/iscsi/iscsi.c
@@ -51,20 +51,7 @@
 #include <time.h>
 
 #include <rte_config.h>
-#include <rte_common.h>
-#include <rte_log.h>
-#include <rte_memcpy.h>
-#include <rte_tailq.h>
-#include <rte_eal.h>
-#include <rte_per_lcore.h>
-#include <rte_launch.h>
-#include <rte_atomic.h>
-#include <rte_lcore.h>
-#include <rte_branch_prediction.h>
-#include <rte_ring.h>
-#include <rte_log.h>
 #include <rte_mempool.h>
-#include <rte_string_fns.h>
 
 #include "spdk/endian.h"
 #include "spdk/env.h"
diff --git a/lib/iscsi/iscsi_subsystem.c b/lib/iscsi/iscsi_subsystem.c
index 1624cf911..158ffaf4f 100644
--- a/lib/iscsi/iscsi_subsystem.c
+++ b/lib/iscsi/iscsi_subsystem.c
@@ -32,27 +32,14 @@
  *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#include <rte_config.h>
-#include <rte_common.h>
-#include <rte_log.h>
-#include <rte_memcpy.h>
-#include <rte_tailq.h>
-#include <rte_eal.h>
-#include <rte_per_lcore.h>
-#include <rte_launch.h>
-#include <rte_atomic.h>
-#include <rte_lcore.h>
-#include <rte_branch_prediction.h>
-#include <rte_ring.h>
-#include <rte_log.h>
-#include <rte_mempool.h>
-#include <rte_string_fns.h>
-#include <rte_version.h>
-
 #include <inttypes.h>
 #include <stddef.h>
 #include <unistd.h>
 
+#include <rte_config.h>
+#include <rte_mempool.h>
+#include <rte_version.h>
+
 #include "iscsi/iscsi.h"
 #include "iscsi/init_grp.h"
 #include "iscsi/portal_grp.h"
diff --git a/lib/nvmf/nvmf.c b/lib/nvmf/nvmf.c
index 771c9d4f8..ae0697fe6 100644
--- a/lib/nvmf/nvmf.c
+++ b/lib/nvmf/nvmf.c
@@ -33,8 +33,6 @@
 
 #include <arpa/inet.h>
 
-#include <rte_config.h>
-
 #include "spdk/log.h"
 #include "spdk/conf.h"
 #include "subsystem.h"
diff --git a/lib/nvmf/rdma.c b/lib/nvmf/rdma.c
index 781d269c0..d5dc34c38 100644
--- a/lib/nvmf/rdma.c
+++ b/lib/nvmf/rdma.c
@@ -40,9 +40,6 @@
 #include <stdio.h>
 #include <stdint.h>
 
-#include <rte_config.h>
-#include <rte_lcore.h>
-
 #include "nvmf_internal.h"
 #include "request.h"
 #include "session.h"
diff --git a/test/lib/bdev/bdevio/bdevio.c b/test/lib/bdev/bdevio/bdevio.c
index a58b104f0..cae1fabd6 100644
--- a/test/lib/bdev/bdevio/bdevio.c
+++ b/test/lib/bdev/bdevio/bdevio.c
@@ -36,10 +36,6 @@
 #include <stdlib.h>
 #include <string.h>
 
-#include <rte_config.h>
-#include <rte_eal.h>
-#include <rte_ring.h>
-
 #include "spdk/bdev.h"
 #include "spdk/copy_engine.h"
 #include "spdk/env.h"
diff --git a/test/lib/bdev/bdevperf/bdevperf.c b/test/lib/bdev/bdevperf/bdevperf.c
index 454e47a71..61f792f5c 100644
--- a/test/lib/bdev/bdevperf/bdevperf.c
+++ b/test/lib/bdev/bdevperf/bdevperf.c
@@ -39,9 +39,7 @@
 #include <unistd.h>
 
 #include <rte_config.h>
-#include <rte_eal.h>
 #include <rte_mempool.h>
-#include <rte_ring.h>
 #include <rte_lcore.h>
 
 #include "spdk/bdev.h"
diff --git a/test/lib/nvme/sgl/nvme_sgl.c b/test/lib/nvme/sgl/nvme_sgl.c
index 81a1ebb9e..c03164ed1 100644
--- a/test/lib/nvme/sgl/nvme_sgl.c
+++ b/test/lib/nvme/sgl/nvme_sgl.c
@@ -38,7 +38,7 @@
 #include <string.h>
 
 #include <rte_config.h>
-#include <rte_lcore.h>
+#include <rte_eal.h>
 
 #include "spdk/nvme.h"
 #include "spdk/env.h"
diff --git a/test/lib/nvmf/nvmf/nvmf_ut.c b/test/lib/nvmf/nvmf/nvmf_ut.c
index b56a853f9..666c6ec79 100644
--- a/test/lib/nvmf/nvmf/nvmf_ut.c
+++ b/test/lib/nvmf/nvmf/nvmf_ut.c
@@ -36,9 +36,6 @@
 #include <errno.h>
 #include <stdio.h>
 
-#include <rte_config.h>
-#include <rte_lcore.h>
-
 #include "spdk_cunit.h"
 
 #include "spdk/string.h"