ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvme: reorder nvme_controller for better packing

Browse Source 
After converting is_resetting to bool, it is smaller and can be packed
more efficiently with is_failed and reordered after the larger fields
used in the I/O path.

Change-Id: Ifa2301eb61ce8d38eb5412cca61d2a91b1474101
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
This commit is contained in:
Daniel Verkamp 2015-11-02 18:02:27 -07:00
parent bc185fe7dc
commit 181de7bf79
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/nvme/nvme_internal.h
View File

@ -233,13 +233,14 @@ struct nvme_controller {
/** I/O queue pairs */ /** I/O queue pairs */
struct nvme_qpair *ioq; struct nvme_qpair *ioq;
bool is_resetting;
uint32_t num_ns;
/** Array of namespaces indexed by nsid - 1 */ /** Array of namespaces indexed by nsid - 1 */
struct nvme_namespace *ns; struct nvme_namespace *ns;
uint32_t num_ns;
bool is_resetting;
bool is_failed;
/* Cold data (not accessed in normal I/O path) is after this point. */ /* Cold data (not accessed in normal I/O path) is after this point. */
@ -262,8 +263,6 @@ struct nvme_controller {
nvme_aer_cb_fn_t aer_cb_fn; nvme_aer_cb_fn_t aer_cb_fn;
void *aer_cb_arg; void *aer_cb_arg;
bool is_failed;
/** guards access to the controller itself, including admin queues */ /** guards access to the controller itself, including admin queues */
nvme_mutex_t ctrlr_lock; nvme_mutex_t ctrlr_lock;