From 17a48266879ba6b4c65656c4fe83488c0e4352c2 Mon Sep 17 00:00:00 2001 From: Shuhei Matsumoto Date: Tue, 22 Dec 2020 20:34:00 +0900 Subject: [PATCH] bdev/nvme: Log if reconnecting I/O qpair failed by WARNLOG We do not know if reconnecting I/O qpair succeeded or failed now. Signed-off-by: Shuhei Matsumoto Change-Id: I030c3d8553efac7878da0fe358a624a502dd8656 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5699 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins Reviewed-by: Changpeng Liu Reviewed-by: Aleksey Marchuk --- module/bdev/nvme/bdev_nvme.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/module/bdev/nvme/bdev_nvme.c b/module/bdev/nvme/bdev_nvme.c index b086e6897..8907dda87 100644 --- a/module/bdev/nvme/bdev_nvme.c +++ b/module/bdev/nvme/bdev_nvme.c @@ -233,12 +233,17 @@ SPDK_BDEV_MODULE_REGISTER(nvme, &nvme_if) static void bdev_nvme_disconnected_qpair_cb(struct spdk_nvme_qpair *qpair, void *poll_group_ctx) { - SPDK_DEBUGLOG(bdev_nvme, "qpar %p is disconnected, attempting reconnect.\n", qpair); + int rc; + + SPDK_DEBUGLOG(bdev_nvme, "qpair %p is disconnected, attempting reconnect.\n", qpair); /* * Currently, just try to reconnect indefinitely. If we are doing a reset, the reset will * reconnect a qpair and we will stop getting a callback for this one. */ - spdk_nvme_ctrlr_reconnect_io_qpair(qpair); + rc = spdk_nvme_ctrlr_reconnect_io_qpair(qpair); + if (rc != 0) { + SPDK_WARNLOG("Failed to reconnect to qpair %p, errno %d\n", qpair, -rc); + } } static int