ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvme: remove nvme_request::timeout field

Browse Source 
This field is write-only in the current code; the NVMe library does
not track timeouts on requests.

Change-Id: I50e53bb3c299bf16912c48be8aad3eec829154af
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
This commit is contained in:
Daniel Verkamp 2016-03-09 14:29:00 -07:00
parent 2374599671
commit 17005b5756
6 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/nvme/nvme.c
View File

@ -149,7 +149,6 @@ nvme_allocate_request(const struct nvme_payload *payload, uint32_t payload_size,
memset(req, 0, offsetof(struct nvme_request, children)); memset(req, 0, offsetof(struct nvme_request, children));
req->cb_fn = cb_fn; req->cb_fn = cb_fn;
req->cb_arg = cb_arg; req->cb_arg = cb_arg;
req->timeout = true;
req->payload = *payload; req->payload = *payload;
req->payload_size = payload_size; req->payload_size = payload_size;

5
lib/nvme/nvme_ctrlr.c
View File

@ -664,11 +664,6 @@ nvme_ctrlr_construct_and_submit_aer(struct spdk_nvme_ctrlr *ctrlr,
return -1; return -1;
} }
/*
* Disable timeout here, since asynchronous event requests should by
* nature never be timed out.
*/
req->timeout = false;
req->cmd.opc = SPDK_NVME_OPC_ASYNC_EVENT_REQUEST; req->cmd.opc = SPDK_NVME_OPC_ASYNC_EVENT_REQUEST;
nvme_ctrlr_submit_admin_request(ctrlr, req); nvme_ctrlr_submit_admin_request(ctrlr, req);

1
lib/nvme/nvme_internal.h
View File

@ -173,7 +173,6 @@ struct nvme_request {
*/ */
struct nvme_payload payload; struct nvme_payload payload;
uint8_t timeout;
uint8_t retries; uint8_t retries;
/** /**

1
test/lib/nvme/unit/nvme_ctrlr_c/nvme_ctrlr_ut.c
View File

@ -252,7 +252,6 @@ nvme_allocate_request(const struct nvme_payload *payload, uint32_t payload_size,
req->cb_fn = cb_fn; req->cb_fn = cb_fn;
req->cb_arg = cb_arg; req->cb_arg = cb_arg;
req->timeout = true;
} }
return req; return req;

1
test/lib/nvme/unit/nvme_ctrlr_cmd_c/nvme_ctrlr_cmd_ut.c
View File

@ -219,7 +219,6 @@ nvme_allocate_request(const struct nvme_payload *payload, uint32_t payload_size,
req->cb_fn = cb_fn; req->cb_fn = cb_fn;
req->cb_arg = cb_arg; req->cb_arg = cb_arg;
req->timeout = true;
return req; return req;
} }

1
test/lib/nvme/unit/nvme_qpair_c/nvme_qpair_ut.c
View File

@ -147,7 +147,6 @@ nvme_allocate_request(const struct nvme_payload *payload, uint32_t payload_size,
memset(req, 0, offsetof(struct nvme_request, children)); memset(req, 0, offsetof(struct nvme_request, children));
req->cb_fn = cb_fn; req->cb_fn = cb_fn;
req->cb_arg = cb_arg; req->cb_arg = cb_arg;
req->timeout = true;
req->payload = *payload; req->payload = *payload;
req->payload_size = payload_size; req->payload_size = payload_size;