ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rdma: disbale send with inval on Soft-RoCE NICs

Browse Source 
Currently, the RXE kernel driver does not support send with invalidate.
There is a change to the kernel making its way downstream that will
enable this feature. At that point, we can conditionally enable
send-with-invalidate based on the kernel version.

Change-Id: I05c7bcbf8ec944be89c10bdf6ccc3229e4586914
Signed-off-by: Seth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/422579
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
This commit is contained in:
Seth Howell 2018-08-16 08:51:04 -07:00 committed by Jim Harris
parent b4de8e1158
commit 1570c87f81
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/nvmf/rdma.c
View File

@ -1145,10 +1145,20 @@ spdk_nvmf_rdma_request_parse_sgl(struct spdk_nvmf_rdma_transport *rtransport,
return -1; return -1;
} }
#ifdef SPDK_CONFIG_RDMA_SEND_WITH_INVAL #ifdef SPDK_CONFIG_RDMA_SEND_WITH_INVAL
/**
* These vendor IDs are assigned by the IEEE and an ID of 0 implies Soft-RoCE.
* The Soft-RoCE RXE driver does not currently support send with invalidate.
* There are changes making their way through the kernel now that will enable
* this feature. When they are merged, we can conditionally enable this feature.
*
* todo: enable this for versions of the kernel rxe driver that support it.
*/
if (device->attr.vendor_id != 0) {
if (sgl->keyed.subtype == SPDK_NVME_SGL_SUBTYPE_INVALIDATE_KEY) { if (sgl->keyed.subtype == SPDK_NVME_SGL_SUBTYPE_INVALIDATE_KEY) {
rdma_req->rsp.wr.opcode = IBV_WR_SEND_WITH_INV; rdma_req->rsp.wr.opcode = IBV_WR_SEND_WITH_INV;
rdma_req->rsp.wr.imm_data = sgl->keyed.key; rdma_req->rsp.wr.imm_data = sgl->keyed.key;
} }
}
#endif #endif
/* fill request length and populate iovs */ /* fill request length and populate iovs */