From 12fcf7e1d5f971deffeb9ed85524b004dbc144f4 Mon Sep 17 00:00:00 2001 From: Tomasz Zawadzki Date: Tue, 13 Jul 2021 07:13:04 -0400 Subject: [PATCH] lib/event: remove get/set_core_freqs API from governor Those calls went unused, in favor or much more useful up/down/min/max variants. Signed-off-by: Tomasz Zawadzki Change-Id: I432896196a1a6edfc6799c8658df49567f73d457 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8788 Tested-by: SPDK CI Jenkins Community-CI: Broadcom CI Community-CI: Mellanox Build Bot Reviewed-by: Shuhei Matsumoto Reviewed-by: Konrad Sztyber Reviewed-by: Jim Harris --- include/spdk_internal/event.h | 12 ------------ lib/event/dpdk_governor.c | 15 --------------- test/unit/lib/event/reactor.c/reactor_ut.c | 2 -- 3 files changed, 29 deletions(-) diff --git a/include/spdk_internal/event.h b/include/spdk_internal/event.h index 4c99f1d48..6c65edc0b 100644 --- a/include/spdk_internal/event.h +++ b/include/spdk_internal/event.h @@ -172,21 +172,9 @@ struct spdk_governor_capabilities { struct spdk_governor { char *name; - /* freqs - the buffer array to save the frequencies; num - the number of frequencies to get; return - the number of available frequencies */ - uint32_t (*get_core_freqs)(uint32_t lcore_id, uint32_t *freqs, uint32_t num); - /* return - current frequency on success, 0 on failure */ uint32_t (*get_core_curr_freq)(uint32_t lcore_id); - /** - * freq_index - index of available frequencies returned from get_core_freqs call - * - * return - * - 1 on success with frequency changed. - * - 0 on success without frequency changed. - * - Negative on error. - */ - int (*set_core_freq)(uint32_t lcore_id, uint32_t freq_index); int (*core_freq_up)(uint32_t lcore_id); int (*core_freq_down)(uint32_t lcore_id); int (*set_core_freq_max)(uint32_t lcore_id); diff --git a/lib/event/dpdk_governor.c b/lib/event/dpdk_governor.c index 911f3bef5..392058324 100644 --- a/lib/event/dpdk_governor.c +++ b/lib/event/dpdk_governor.c @@ -39,13 +39,6 @@ #include - -static uint32_t -_get_core_freqs(uint32_t lcore_id, uint32_t *freqs, uint32_t num) -{ - return rte_power_freqs(lcore_id, freqs, num); -} - static uint32_t _get_core_curr_freq(uint32_t lcore_id) { @@ -70,12 +63,6 @@ _get_core_curr_freq(uint32_t lcore_id) return freqs[freq_index]; } -static int -_set_core_freq(uint32_t lcore_id, uint32_t freq_index) -{ - return rte_power_set_freq(lcore_id, freq_index); -} - static int _core_freq_up(uint32_t lcore_id) { @@ -163,9 +150,7 @@ _deinit_core(uint32_t lcore_id) static struct spdk_governor dpdk_governor = { .name = "dpdk_governor", - .get_core_freqs = _get_core_freqs, .get_core_curr_freq = _get_core_curr_freq, - .set_core_freq = _set_core_freq, .core_freq_up = _core_freq_up, .core_freq_down = _core_freq_down, .set_core_freq_max = _set_core_freq_max, diff --git a/test/unit/lib/event/reactor.c/reactor_ut.c b/test/unit/lib/event/reactor.c/reactor_ut.c index fd7160426..79e47aa4d 100644 --- a/test/unit/lib/event/reactor.c/reactor_ut.c +++ b/test/unit/lib/event/reactor.c/reactor_ut.c @@ -764,9 +764,7 @@ core_freq_max(uint32_t lcore) static struct spdk_governor governor = { .name = "dpdk_governor", - .get_core_freqs = NULL, .get_core_curr_freq = NULL, - .set_core_freq = NULL, .core_freq_up = core_freq_up, .core_freq_down = core_freq_down, .set_core_freq_max = core_freq_max,