From 11e67d93ffeca5e313bc265b0266f0bf9d446352 Mon Sep 17 00:00:00 2001 From: John Levon Date: Thu, 12 Jan 2023 16:45:35 +0000 Subject: [PATCH] lib/nvmf: sanity check req->iovcnt If req->data is set, with all the previous changes, then req->iovcnt should also be more than zero. Signed-off-by: John Levon Change-Id: I29b5f45541c9dba2dd896109dd43d2b5321ec467 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16274 Reviewed-by: Jim Harris Tested-by: SPDK CI Jenkins Reviewed-by: Ben Walker --- lib/nvmf/ctrlr.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/nvmf/ctrlr.c b/lib/nvmf/ctrlr.c index b0370b642..8bb7d88c5 100644 --- a/lib/nvmf/ctrlr.c +++ b/lib/nvmf/ctrlr.c @@ -4498,6 +4498,10 @@ spdk_nvmf_request_exec(struct spdk_nvmf_request *req) struct spdk_nvmf_transport *transport = qpair->transport; enum spdk_nvmf_request_exec_status status; + if (req->data != NULL) { + assert(req->iovcnt > 0); + } + if (!nvmf_check_subsystem_active(req)) { return; }