ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: Shellcheck - move rule SC2223 to permanent exception list.

Browse Source 
This rule won't be used in bash scripts and will be added to exception list.
SC2223 - This default assignment may cause DoS due to globbing. Quote it.

Change-Id: I0d4b0bc697e42bb4bc1d77db5b28a469cdb887ec
Signed-off-by: Pawel Kaminski <pawelx.kaminski@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/466836
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Maciej Wawryk <maciejx.wawryk@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
This commit is contained in:
Pawel Kaminski 2019-08-29 16:51:49 -04:00 committed by Tomasz Zawadzki
parent 9c6e742679
commit 117710eed1
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
scripts/check_format.sh
View File

@ -248,7 +248,7 @@ SC2068,SC2086,SC2089,SC2090,\
SC2097,SC2098,SC2103,SC2115,SC2116,SC2119,SC2120,SC2121,SC2124,SC2126,SC2128,\
SC2129,SC2140,SC2142,SC2143,SC2145,SC2146,SC2148,SC2152,SC2153,SC2154,SC2155,\
SC2162,SC2164,SC2165,SC2166,SC2167,SC2174,\
SC2206,SC2207,SC2223,SC2230,SC2231"
SC2206,SC2207,SC2230,SC2231"
# SPDK fails some error checks which have been deprecated in later versions of shellcheck.
# We will not try to fix these error checks, but instead just leave the error types here
# so that we can still run with older versions of shellcheck.
@ -257,7 +257,8 @@ SC2206,SC2207,SC2223,SC2230,SC2231"
# We are aware about below exclude list and we want this errors to be excluded.
# SC1090: Can't follow non-constant source. Use a directive to specify location.
# SC1091: Not following: (error message here)
SHCK_EXCLUDE="$SHCK_EXCLUDE,SC1090,SC1091"
# SC2223: This default assignment may cause DoS due to globbing. Quote it.
SHCK_EXCLUDE="$SHCK_EXCLUDE,SC1090,SC1091,SC2223"
SHCK_FORMAT="diff"
SHCK_APPLY=true