From 10dbbf6d8a878adb4e7460f79822ff1eb29d16dc Mon Sep 17 00:00:00 2001 From: Konrad Sztyber Date: Tue, 17 May 2022 14:03:54 +0200 Subject: [PATCH] bdev/nvme: free log_page when freeing discovery ctx Currently this should be a no-op as the log_page is always freed in discovery_remove_controllers(), but it'll make it easier to handle cases when we want to stop the discovery service while it's attaching NVM controllers. We'll be relying on this in the subsequent patch adding attach timeout to start_discovery(). Signed-off-by: Konrad Sztyber Change-Id: Ia03fde92bf5ae5590bca507b7a0f963885d85f4f Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12721 Community-CI: Broadcom CI Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Jim Harris Reviewed-by: Aleksey Marchuk Reviewed-by: Shuhei Matsumoto Reviewed-by: Dong Yi --- module/bdev/nvme/bdev_nvme.c | 1 + 1 file changed, 1 insertion(+) diff --git a/module/bdev/nvme/bdev_nvme.c b/module/bdev/nvme/bdev_nvme.c index 729b48f89..eff2d194b 100644 --- a/module/bdev/nvme/bdev_nvme.c +++ b/module/bdev/nvme/bdev_nvme.c @@ -4820,6 +4820,7 @@ static void get_discovery_log_page(struct discovery_ctx *ctx); static void free_discovery_ctx(struct discovery_ctx *ctx) { + free(ctx->log_page); free(ctx->hostnqn); free(ctx->name); free(ctx);