From 10cd9e86b93baf9f3230d02b11dca74d00b0a7d2 Mon Sep 17 00:00:00 2001 From: Changpeng Liu Date: Sun, 15 Dec 2019 23:37:13 -0500 Subject: [PATCH] UT/nvme: use STUB macro for the empty function APIs Change-Id: Id037a0cdc1e054dad0454e0897b04629b78e7d50 Signed-off-by: Changpeng Liu Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/478018 Tested-by: SPDK CI Jenkins Community-CI: SPDK CI Jenkins Reviewed-by: Alexey Marchuk Reviewed-by: Jim Harris Reviewed-by: Shuhei Matsumoto Reviewed-by: Ben Walker --- .../lib/nvme/nvme_qpair.c/nvme_qpair_ut.c | 24 ++++--------------- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/test/unit/lib/nvme/nvme_qpair.c/nvme_qpair_ut.c b/test/unit/lib/nvme/nvme_qpair.c/nvme_qpair_ut.c index 6037b3bf2..857efbd35 100644 --- a/test/unit/lib/nvme/nvme_qpair.c/nvme_qpair_ut.c +++ b/test/unit/lib/nvme/nvme_qpair.c/nvme_qpair_ut.c @@ -48,6 +48,11 @@ struct nvme_driver _g_nvme_driver = { .lock = PTHREAD_MUTEX_INITIALIZER, }; +DEFINE_STUB_V(nvme_transport_qpair_abort_reqs, (struct spdk_nvme_qpair *qpair, uint32_t dnr)); +DEFINE_STUB(nvme_transport_qpair_submit_request, int, + (struct spdk_nvme_qpair *qpair, struct nvme_request *req), 0); +DEFINE_STUB(spdk_nvme_ctrlr_free_io_qpair, int, (struct spdk_nvme_qpair *qpair), 0); + void nvme_ctrlr_fail(struct spdk_nvme_ctrlr *ctrlr, bool hot_remove) { @@ -57,19 +62,6 @@ nvme_ctrlr_fail(struct spdk_nvme_ctrlr *ctrlr, bool hot_remove) ctrlr->is_failed = true; } -void -nvme_transport_qpair_abort_reqs(struct spdk_nvme_qpair *qpair, uint32_t dnr) -{ -} - -int -nvme_transport_qpair_submit_request(struct spdk_nvme_qpair *qpair, struct nvme_request *req) -{ - /* TODO */ - return 0; -} - - static bool g_called_transport_process_completions = false; static int32_t g_transport_process_completions_rc = 0; int32_t @@ -79,12 +71,6 @@ nvme_transport_qpair_process_completions(struct spdk_nvme_qpair *qpair, uint32_t return g_transport_process_completions_rc; } -int -spdk_nvme_ctrlr_free_io_qpair(struct spdk_nvme_qpair *qpair) -{ - return 0; -} - static void prepare_submit_request_test(struct spdk_nvme_qpair *qpair, struct spdk_nvme_ctrlr *ctrlr)