From 10717b577c6500e30e55ad459b7b0cd411a460d1 Mon Sep 17 00:00:00 2001
From: yidong0635 <dongx.yi@intel.com>
Date: Thu, 24 Dec 2020 04:50:28 -0500
Subject: [PATCH] nvme/nvme_transport: Unify returns in disconnect and connect.

Here "return rc == -EINPROGRESS ? 0 : rc;"
They  are the same meaning in these two functions.
Keep the comments here. This makes more clear to readers.

Signed-off-by: yidong0635 <dongx.yi@intel.com>
Change-Id: I8590de3f0fe27337163ee8b02ea63e166f1bbe7c
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5689
Community-CI: Broadcom CI
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
---
 lib/nvme/nvme_transport.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/lib/nvme/nvme_transport.c b/lib/nvme/nvme_transport.c
index a0a02a271..30501633f 100644
--- a/lib/nvme/nvme_transport.c
+++ b/lib/nvme/nvme_transport.c
@@ -554,10 +554,9 @@ nvme_transport_poll_group_disconnect_qpair(struct spdk_nvme_qpair *qpair)
 			/* EINPROGRESS indicates that a call has already been made to this function.
 			 * It just keeps us from segfaulting on a double removal/insert.
 			 */
-		} else if (rc == -EINPROGRESS) {
-			rc = 0;
 		}
-		return rc;
+
+		return rc == -EINPROGRESS ? 0 : rc;
 	}
 
 	return -EINVAL;