From 0fd4c1f97c7e39eca56a5bc915aa17cd1b9394b2 Mon Sep 17 00:00:00 2001 From: wanghailiangx Date: Wed, 13 Jan 2021 05:45:20 -0500 Subject: [PATCH] example/nvme/plugin: Fix a notice error of bs We konw bs should be extended_sector_size(ns) * num_blocks. In other words, bs should be an integral multiple of extended_sector_size. num_blocks cannot be got here, so we used integral multiple. Change-Id: Ie521db194cdad6f2d2247fd2704cab92c36ddb82 Signed-off-by: wanghailiangx Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5881 Tested-by: SPDK CI Jenkins Reviewed-by: Changpeng Liu Reviewed-by: Shuhei Matsumoto Reviewed-by: Jim Harris --- examples/nvme/fio_plugin/fio_plugin.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/nvme/fio_plugin/fio_plugin.c b/examples/nvme/fio_plugin/fio_plugin.c index 926c015ca..03a47d3fb 100644 --- a/examples/nvme/fio_plugin/fio_plugin.c +++ b/examples/nvme/fio_plugin/fio_plugin.c @@ -401,8 +401,8 @@ attach_cb(void *cb_ctx, const struct spdk_nvme_transport_id *trid, } if (spdk_nvme_ns_supports_extended_lba(ns) && - (spdk_nvme_ns_get_extended_sector_size(ns) != td->o.bs[DDIR_READ] || - spdk_nvme_ns_get_extended_sector_size(ns) != td->o.bs[DDIR_WRITE])) { + (td->o.bs[DDIR_READ] % spdk_nvme_ns_get_extended_sector_size(ns) != 0 || + td->o.bs[DDIR_WRITE] % spdk_nvme_ns_get_extended_sector_size(ns) != 0)) { SPDK_ERRLOG("--bs has to be equal to LBA data size + Metadata size\n"); g_error = true; return;