From 0f99e7ab9e830e177c23dd4e28d8acd575d5038c Mon Sep 17 00:00:00 2001 From: Daniel Verkamp Date: Mon, 16 Apr 2018 13:56:27 -0700 Subject: [PATCH] nvmf: report that namespaces may be shared The namespaces exposed by the NVMe-oF target may be attached to multiple (virtual) controllers at once, so we should indicate this via the Namespace Multi-path I/O and Namespace Sharing Capabilities (NMIC) field in the Identify Namespace data. Change-Id: Iecca80f01577422f73d781c05dcb212db55f7ee1 Signed-off-by: Daniel Verkamp Reviewed-on: https://review.gerrithub.io/407834 Tested-by: SPDK Automated Test System Reviewed-by: Ben Walker Reviewed-by: Changpeng Liu --- lib/nvmf/ctrlr_bdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/nvmf/ctrlr_bdev.c b/lib/nvmf/ctrlr_bdev.c index f5eea59f6..93c7423dc 100644 --- a/lib/nvmf/ctrlr_bdev.c +++ b/lib/nvmf/ctrlr_bdev.c @@ -117,6 +117,7 @@ spdk_nvmf_bdev_ctrlr_identify_ns(struct spdk_nvmf_ns *ns, struct spdk_nvme_ns_da nsdata->flbas.format = 0; nsdata->lbaf[0].lbads = spdk_u32log2(spdk_bdev_get_block_size(bdev)); nsdata->noiob = spdk_bdev_get_optimal_io_boundary(bdev); + nsdata->nmic.can_share = 1; SPDK_STATIC_ASSERT(sizeof(nsdata->nguid) == sizeof(ns->opts.nguid), "size mismatch"); memcpy(nsdata->nguid, ns->opts.nguid, sizeof(nsdata->nguid));