From 0e41ee0b83ebf3d1f0982a8e8d2760f04450f900 Mon Sep 17 00:00:00 2001 From: Mike Gerdts Date: Tue, 14 Mar 2023 01:04:50 -0500 Subject: [PATCH] lvol: remove unused lvol->thin_provision The thin_provision member of struct spdk_lvol is set but never used. When needed, an lvol's thin provision state is obtained by looking at the lvol's blob. This removes the unused thin_provision member. Signed-off-by: Mike Gerdts Change-Id: I5a2048b5334a26772a25a0bd238e42d3aeb63b49 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17173 Tested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Jim Harris Community-CI: Mellanox Build Bot --- include/spdk_internal/lvolstore.h | 1 - lib/lvol/lvol.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/include/spdk_internal/lvolstore.h b/include/spdk_internal/lvolstore.h index 9db4b2c95..770a7bed5 100644 --- a/include/spdk_internal/lvolstore.h +++ b/include/spdk_internal/lvolstore.h @@ -88,7 +88,6 @@ struct spdk_lvol { char name[SPDK_LVOL_NAME_MAX]; struct spdk_uuid uuid; char uuid_str[SPDK_UUID_STRING_LEN]; - bool thin_provision; struct spdk_bdev *bdev; int ref_count; bool action_in_progress; diff --git a/lib/lvol/lvol.c b/lib/lvol/lvol.c index 987be639d..b3e762bc7 100644 --- a/lib/lvol/lvol.c +++ b/lib/lvol/lvol.c @@ -184,7 +184,6 @@ load_next_lvol(void *cb_arg, struct spdk_blob *blob, int lvolerrno) */ lvol->blob_id = blob_id; lvol->lvol_store = lvs; - lvol->thin_provision = spdk_blob_is_thin_provisioned(blob); rc = spdk_blob_get_xattr_value(blob, "uuid", (const void **)&attr, &value_len); if (rc != 0 || value_len != SPDK_UUID_STRING_LEN || attr[SPDK_UUID_STRING_LEN - 1] != '\0' || @@ -1040,7 +1039,6 @@ spdk_lvol_create(struct spdk_lvol_store *lvs, const char *name, uint64_t sz, } lvol->lvol_store = lvs; num_clusters = spdk_divide_round_up(sz, spdk_bs_get_cluster_size(bs)); - lvol->thin_provision = thin_provision; lvol->clear_method = (enum blob_clear_method)clear_method; snprintf(lvol->name, sizeof(lvol->name), "%s", name); TAILQ_INSERT_TAIL(&lvol->lvol_store->pending_lvols, lvol, link);