From 0db73d0975c12ab2c78dac0074dc2f73f9fac9e3 Mon Sep 17 00:00:00 2001 From: Pawel Kaminski Date: Wed, 18 Dec 2019 09:35:34 -0500 Subject: [PATCH] test/lvol: Fix - improve checking failed commands Instead of using "!" use rpc_cmd && false to check that command should fail but succeded Change-Id: Ied564c13b96ea6d4a45aab1460b3323edd1d9554 Signed-off-by: Pawel Kaminski Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/478328 Community-CI: SPDK CI Jenkins Tested-by: SPDK CI Jenkins Reviewed-by: Paul Luse Reviewed-by: Jim Harris Reviewed-by: Shuhei Matsumoto Reviewed-by: Karol Latecki --- test/lvol/basic.sh | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/lvol/basic.sh b/test/lvol/basic.sh index 789317fc2..c4c7e39f2 100755 --- a/test/lvol/basic.sh +++ b/test/lvol/basic.sh @@ -26,7 +26,7 @@ function test_construct_lvs() { # remove it and verify it's gone rpc_cmd bdev_lvol_delete_lvstore -u "$lvs_uuid" - ! rpc_cmd bdev_lvol_get_lvstores -u "$lvs_uuid" + rpc_cmd bdev_lvol_get_lvstores -u "$lvs_uuid" && false rpc_cmd bdev_malloc_delete "$malloc_name" check_leftover_devices } @@ -50,7 +50,7 @@ function test_construct_lvol() { # clean up and create another lvol, this time use lvs alias instead of uuid rpc_cmd bdev_lvol_delete "$lvol_uuid" - ! rpc_cmd bdev_get_bdevs -b "$lvol_uuid" + rpc_cmd bdev_get_bdevs -b "$lvol_uuid" && false lvol_uuid=$(rpc_cmd bdev_lvol_create -l lvs_test lvol_test "$LVS_DEFAULT_CAPACITY_MB") lvol=$(rpc_cmd bdev_get_bdevs -b "$lvol_uuid") @@ -63,9 +63,9 @@ function test_construct_lvol() { # clean up rpc_cmd bdev_lvol_delete "$lvol_uuid" - ! rpc_cmd bdev_get_bdevs -b "$lvol_uuid" + rpc_cmd bdev_get_bdevs -b "$lvol_uuid" && false rpc_cmd bdev_lvol_delete_lvstore -u "$lvs_uuid" - ! rpc_cmd bdev_lvol_get_lvstores -u "$lvs_uuid" + rpc_cmd bdev_lvol_get_lvstores -u "$lvs_uuid" && false rpc_cmd bdev_malloc_delete "$malloc_name" check_leftover_devices } @@ -127,7 +127,7 @@ function test_construct_multi_lvols() { [ "$(jq length <<< "$lvols")" == "0" ] rpc_cmd bdev_lvol_delete_lvstore -u "$lvs_uuid" - ! rpc_cmd bdev_lvol_get_lvstores -u "$lvs_uuid" + rpc_cmd bdev_lvol_get_lvstores -u "$lvs_uuid" && false rpc_cmd bdev_malloc_delete "$malloc_name" check_leftover_devices }