From 0c980660b612c3501d0987e3246b6ea224e1fb73 Mon Sep 17 00:00:00 2001 From: GangCao Date: Wed, 3 Aug 2022 21:44:54 -0400 Subject: [PATCH] FTL: move assert earlier before accessing the field Fix Klockwork issue. Change-Id: Iae9557c152a745549c8963f4f0510ae829f871a4 Signed-off-by: GangCao Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13860 Community-CI: Mellanox Build Bot Community-CI: Broadcom CI Reviewed-by: Dong Yi Reviewed-by: Changpeng Liu Reviewed-by: Jim Harris Tested-by: SPDK CI Jenkins --- lib/ftl/mngt/ftl_mngt_md.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/ftl/mngt/ftl_mngt_md.c b/lib/ftl/mngt/ftl_mngt_md.c index bcf13641f..dfcf82531 100644 --- a/lib/ftl/mngt/ftl_mngt_md.c +++ b/lib/ftl/mngt/ftl_mngt_md.c @@ -103,10 +103,11 @@ persist(struct spdk_ftl_dev *dev, struct ftl_mngt_process *mngt, enum ftl_layout_region_type type) { struct ftl_layout *layout = &dev->layout; - struct ftl_md *md = layout->md[type]; + struct ftl_md *md; assert(type < FTL_LAYOUT_REGION_TYPE_MAX); + md = layout->md[type]; if (!md) { ftl_mngt_fail_step(mngt); return;