From 0c471fd6681571d52a3063c3cd53e58f06fa1e3b Mon Sep 17 00:00:00 2001 From: Dariusz Stojaczyk Date: Fri, 16 Jun 2017 15:13:36 +0200 Subject: [PATCH] vhost_scsi: enable VIRTIO_SCSI_F_CHANGE flag As of virtio spec 1.0, driver must not accept flags which the device did not offer (section 2.2). However, that flag is apparently being accepted, causing silent exception to be triggered in rte_vhost. This results in all negotiated features to be rejected in rte_vhost. This patch is a workaround. Enabling that flag does not enforce us to do any additional actions. Change-Id: Iede0c0360de33d438f109442c7a83231e9d4479e Signed-off-by: Dariusz Stojaczyk Reviewed-on: https://review.gerrithub.io/365806 Tested-by: SPDK Automated Test System Reviewed-by: Daniel Verkamp Reviewed-by: Jim Harris --- lib/vhost/vhost_scsi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/vhost/vhost_scsi.c b/lib/vhost/vhost_scsi.c index 00ee272f1..332e8c633 100644 --- a/lib/vhost/vhost_scsi.c +++ b/lib/vhost/vhost_scsi.c @@ -58,11 +58,9 @@ /* Features that are specified in VIRTIO SCSI but currently not supported: * - Live migration not supported yet - * - LUN params change * - T10 PI */ #define SPDK_VHOST_SCSI_DISABLED_FEATURES ((1ULL << VHOST_F_LOG_ALL) | \ - (1ULL << VIRTIO_SCSI_F_CHANGE ) | \ (1ULL << VIRTIO_SCSI_F_T10_PI )) #define MGMT_POLL_PERIOD_US (1000 * 5)