From 0c2a320bcd8d851e15358b572b56924a717bae11 Mon Sep 17 00:00:00 2001
From: Pawel Wodkowski <pawelx.wodkowski@intel.com>
Date: Fri, 12 Oct 2018 15:00:40 +0200
Subject: [PATCH] iscsi, rpc: free init options if decoding failed

Detected aby ASAN


Change-Id: I49f160ddc20334a147f39c39015cb340d29f722b
Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
Reviewed-on: https://review.gerrithub.io/429227
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
---
 lib/event/subsystems/iscsi/iscsi_rpc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/event/subsystems/iscsi/iscsi_rpc.c b/lib/event/subsystems/iscsi/iscsi_rpc.c
index 49c3de0e5..fb96be070 100644
--- a/lib/event/subsystems/iscsi/iscsi_rpc.c
+++ b/lib/event/subsystems/iscsi/iscsi_rpc.c
@@ -93,6 +93,7 @@ spdk_rpc_iscsi_set_opts(struct spdk_jsonrpc_request *request,
 			SPDK_ERRLOG("spdk_json_decode_object() failed\n");
 			spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS,
 							 "Invalid parameters");
+			spdk_iscsi_opts_free(opts);
 			return;
 		}
 	}