From 0bac3197b8e3133fe175dea2ac0d4b5c43ae48e1 Mon Sep 17 00:00:00 2001 From: Shuhei Matsumoto Date: Tue, 31 Jan 2023 11:52:14 +0900 Subject: [PATCH] iscsi: Use error_response() rather than bool_response(false) for JSON RPC For JSON RPC, boolean response with false value may not be regarded as error. Previously many cases were replaced to use spdk_jsonrpc_send_error_response() explicitly. Replace one of the remaining cases in this patch. Signed-off-by: Shuhei Matsumoto Change-Id: Ibfcb8c53662238b7ba8f08ecd1678953af8dc202 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16622 Reviewed-by: Jim Harris Reviewed-by: Aleksey Marchuk Tested-by: SPDK CI Jenkins --- lib/iscsi/iscsi_rpc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/iscsi/iscsi_rpc.c b/lib/iscsi/iscsi_rpc.c index 4d8de4953..51656734f 100644 --- a/lib/iscsi/iscsi_rpc.c +++ b/lib/iscsi/iscsi_rpc.c @@ -587,7 +587,11 @@ rpc_iscsi_delete_target_node_done(void *cb_arg, int rc) struct rpc_iscsi_delete_target_node_ctx *ctx = cb_arg; free_rpc_iscsi_delete_target_node(&ctx->req); - spdk_jsonrpc_send_bool_response(ctx->request, rc == 0); + if (rc == 0) { + spdk_jsonrpc_send_bool_response(ctx->request, true); + } else { + spdk_jsonrpc_send_error_response(ctx->request, rc, spdk_strerror(-rc)); + } free(ctx); }