From 0aac63ce629700504b5911e41b2a6dfb573e86c1 Mon Sep 17 00:00:00 2001 From: Jim Harris Date: Mon, 8 Feb 2021 21:35:36 +0000 Subject: [PATCH] bdevperf: do not append cpumask to thread name spdk_thread_create() does not require unique thread names, and we already print out the CPU mask for each job. So there is no need to append the cpumask to the thread name. Removing it has the added advantage of not modifying the job name specified by the user if they are using a job config file. Signed-off-by: Jim Harris Change-Id: I6d75ea2bdc50061d7338ad41749e458efa62b48e Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6331 Tested-by: SPDK CI Jenkins Reviewed-by: Paul Luse Reviewed-by: Changpeng Liu Reviewed-by: Reviewed-by: Aleksey Marchuk Community-CI: Mellanox Build Bot --- test/bdev/bdevperf/bdevperf.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/test/bdev/bdevperf/bdevperf.c b/test/bdev/bdevperf/bdevperf.c index f8b51c387..e2aab8a41 100644 --- a/test/bdev/bdevperf/bdevperf.c +++ b/test/bdev/bdevperf/bdevperf.c @@ -1118,7 +1118,6 @@ typedef struct spdk_thread *spdk_thread_t; static spdk_thread_t construct_job_thread(struct spdk_cpuset *cpumask, const char *tag) { - char thread_name[32]; struct spdk_cpuset tmp; /* This function runs on the main thread. */ @@ -1136,11 +1135,7 @@ construct_job_thread(struct spdk_cpuset *cpumask, const char *tag) fprintf(stderr, "cpumask for '%s' is too big\n", tag); } - snprintf(thread_name, sizeof(thread_name), "%s_%s", - tag, - spdk_cpuset_fmt(cpumask)); - - return spdk_thread_create(thread_name, cpumask); + return spdk_thread_create(tag, cpumask); } static uint32_t