ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bdev/nvme: use stop_discovery in module_fini

Browse Source 
Using stop_discovery() will also free the entry contexts tied to that
discovery service.  It's not a big deal to leave them, as module_fini is
usually called on app shutdown, but this gets rid of asan reporting
memory leaks.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I81fc843708694791a5846c24cbde4b32e0fa7287
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12683
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
This commit is contained in:
Konrad Sztyber 2022-05-12 16:24:14 +02:00 committed by Tomasz Zawadzki
parent 82889ba8e5
commit 0aa212bddb
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
module/bdev/nvme/bdev_nvme.c
View File

@ -5356,8 +5356,7 @@ bdev_nvme_library_fini(void)
bdev_nvme_fini_destruct_ctrlrs();
} else {
TAILQ_FOREACH(ctx, &g_discovery_ctxs, tailq) {
ctx->stop = true;
ctx->stop_cb_fn = check_discovery_fini;
stop_discovery(ctx, check_discovery_fini, NULL);
}
}
}