ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bdev_nvme_rpc: NULL check for multipath

Browse Source 
Pointer 'ctx->req.multipath' returned from call to
function 'strdup' may be NULL. Reported by Klocwork.

Change-Id: Id4a188ec5340f02c9bd0643db0acb03409dd5829
Signed-off-by: Liu Xiaodong <xiaodong.liu@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9843
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: GangCao <gang.cao@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
This commit is contained in:
Liu Xiaodong 2021-10-12 18:58:11 -04:00 committed by Keith Lucas
parent f2c7c28b2b
commit 0a33bda593
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
module/bdev/nvme/bdev_nvme_rpc.c
View File

@ -398,6 +398,10 @@ rpc_bdev_nvme_attach_controller(struct spdk_jsonrpc_request *request,
"it was used to add a failover path. This behavior will default to rejecting " "it was used to add a failover path. This behavior will default to rejecting "
"the request in the future. Specify the 'multipath' parameter to control the behavior"); "the request in the future. Specify the 'multipath' parameter to control the behavior");
ctx->req.multipath = strdup("failover"); ctx->req.multipath = strdup("failover");
if (ctx->req.multipath == NULL) {
SPDK_ERRLOG("cannot allocate multipath failover string\n");
goto cleanup;
}
} }
opts = spdk_nvme_ctrlr_get_opts(ctrlr->ctrlr); opts = spdk_nvme_ctrlr_get_opts(ctrlr->ctrlr);